Problem/Motivation

Steps to reproduce

  1. Go to a cart page with registration status 'Pending'.
  2. Click the button 'Cancel order'.
  3. Go back to the same cart page.
  4. The registration status is still 'Pending'.

Proposed resolution

Change the registration status to 'Canceled' when a cart is canceled.

Issue fork commerce_registration-3419927

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

franceslui created an issue. See original summary.

franceslui’s picture

franceslui commented

Our workshop has a limit of certain number of registrations, so we would like to cancel some carts to free up some spaces for new registrations.

I also notice another related issue that cancelling a registration does not change cart status to 'Canceled'.

Because of these two issues, we have to cancel pending registrations and carts separately.

john.oltman made their first commit to this issue’s fork.

john.oltman opened merge request !8

  • john.oltman committed e22b7e1b on 3.1.x 
    Issue #3419927: Cancelling a cart does not change registration status to...
john.oltman’s picture

john.oltman commented
Status: Active » Fixed
franceslui’s picture

franceslui commented

@john.oltman I greatly appreciate your help of fixing it so quickly! Have a nice day!

franceslui’s picture

franceslui commented
Status: Fixed » Needs review

@john.oltman Thank you again for fixing the issue mentioned in its description.

Do you think that you could also fix the related issue mentioned in comment #2: cancelling a registration does not change cart status to 'Canceled'? I would say that if a cart contains only a registration, canceling this registration should also cancel the cart. What do you think?

john.oltman’s picture

john.oltman commented
Status: Needs review » Fixed

Hi @franceslui, the module does already automatically remove items from the cart for canceled registrations. If this is not happening for you, please double check your order refresh settings for the order type - you can open a new issue if you cannot get this working. It would not be appropriate to cancel an entire cart since the user may have other items in the cart they still want to purchase.

Also, please leave this issue in Fixed status since it was part of a release. You can continue to ask questions when an issue is in Fixed status. "Needs review" is when you have contributed code and are asking a maintainer to review the work and potentially commit it to the module. Thanks!

franceslui’s picture

franceslui commented
Status: Fixed » Active

@john.oltman Thank you very much again for fixing the issue.

I am sorry that I mistakenly changed the status from 'Fixed' to 'Needs review'.

Your opinion about my suggested change makes sense to me. Thank you for that too and have a nice day!

franceslui’s picture

franceslui commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.