Problem/Motivation

PHPUnit is deprecating withConsecutive(), so we need to find replacements.

Steps to reproduce

Proposed resolution

Convert the test to use Prophecy instead.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3419349

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !6465

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

Unsure why PHPStan doesn't pick this one up.

We can't use Argument::containingString() because the argument is TranslatableMarkup. Declaring string $subject in the closure is enough to cast this to a string for str_contains(), though.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Doesn't appear to have lost coverage.

  • catch committed c5db4bb2 on 11.x 
    Issue #3419349 by longwave: Remove withConsecutive() in...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.