Problem/Motivation

PHPUnit is deprecating withConsecutive(), so we need to find replacements.

Steps to reproduce

Proposed resolution

In two cases, we need to assert that two separate messages are logged. To me the order is unimportant as long as the messages are both logged, so we can use Prophecy to do this more easily.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3418178

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !6395

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Parent issue: #3417528: Remove withConsecutive() in MigrateSqlIdMapEnsureTablesTest » #3406006: [META] Convert use of InvocationMocker::withConsecutive()
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Comment was just wow that was the conversion needed.

But tests are still green and nothing broken.

  • catch committed 66a4c78b on 11.x 
    Issue #3418178 by longwave: Remove withConsecutive() in CronQueueTest
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Yeah it's much more readable, good that these changes actually improve the tests a bit.

Committed/pushed to 11.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.