The stymiee/email-validator library has localDisposableOnly and localFreeOnly configuration parameters. These parameters would be useful when webserver can't make external requests, or site admin just wan't to have full control of blacklisted domains.

Issue fork advanced_email_validation-3417829

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

k-l created an issue. See original summary.

k-l opened merge request !14

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Active » Needs work

This is fantastic, thank you, great work. I've marked just one nitpick but otherwise this is ready to ship. I'm happy to make the change myself and commit but I ran out of time this morning.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Issue tags: +Needs tests

Oh I forgot about tests, it would be really great if this had a test.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Version: 1.1.5 » 1.x-dev
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs work » Postponed
Issue tags: -Needs tests

The test has uncovered the fact that the provider results get statically cached in each request. If we change the configuration part way through (say if we're validating a different field that has a different set of overrides) we're going to run into issues. We'll need to get that sorted out before we can commit this.

I'll raise a PR on the external library if I can figure out how to make it work. Postponing on that.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

Ah there's already an issue raised and the maintainer self-assigned yesterday, good timing :)

https://github.com/stymiee/email-validator/issues/5

(usernames don't match exactly but I suspect it was you who raised in January @k-l, thank you!)

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Postponed » Needs review

https://github.com/stymiee/email-validator/releases/tag/1.1.4 just came out which should unstick this, running the tests again now.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs review » Needs work

Tests passed. Think we'd better bump the minimum version of the library since that's required to solve this bug.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs work » Reviewed & tested by the community

  • darvanen committed e28342ae on 1.0.x authored by k-l 
    Issue #3417829 by darvanen, k-l: Add support for localDisposableOnly and...
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Reviewed & tested by the community » Fixed

Thanks so much for your work on this @k-l :)

  • k-l authored e21ea866 on 1.x 
    Issue #3417829 by darvanen, k-l: Add support for localDisposableOnly and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.