Problem/Motivation

PHPUnit is deprecating withConsecutive(), so we need to find replacements.

Steps to reproduce

Proposed resolution

Based on #3306554-29: InvocationMocker::withConsecutive() is deprecated in PHPUnit 9.6 and removed from PHPUnit 10 we can use callbacks to assert the order of arguments.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3417560

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !6349

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Change looks good/no coverage lost.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Needs a rebase.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

Rebased.

  • catch committed 77a137f2 on 10.2.x 
    Issue #3417560 by longwave: Remove withConsecutive() in...

  • catch committed 74fac8eb on 11.x 
    Issue #3417560 by longwave: Remove withConsecutive() in...
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Fixed

Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

longwave closed merge request !6349

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.