Problem/Motivation
footer_menu & footer_top components were split from footer component on year ago, many months before the addition of links setting type: #3341066: [beta1]⚠️ Avoid manually injected HTML in footer component
Those 2 components have:
- a single
linksprop (setting) - no slots (fields)
- no variant for footer_top, 1 variants for footer_bottom
So, having them a separate components seems to be... useless.
Proposed resolution
So, in footer component, why not replacing:
- the top slot by a links prop
- the content slot by a links prop (and a select prop for the variants?)
Remaining tasks
Before doing the change, let's consider why we may wan to keep those components separated: page.html.twig
When we hardcode the call to a component from this template, we make its slots "configurable", because these are the regions where we put the blocks, but not its props. So menus will not be available anymore.
API changes
Breaking, that's why we target beta 6 (which is embedding all the breaking changes about links type)
Issue fork ui_suite_dsfr-3417519
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
pdureau commentedthere is a solution cooking on UI SUite USWDS theme:
On theme settings:
it looks like the links settings type, but simpler.
On page preprocess:
once again, ike the links settings type, but simple.
Comment #3
pdureau commentedLet's wait the work is merged on USWDS before borrowing.
Comment #5
pdureau commented"Footer top" done.
Do we do "Footer Menu" ?
Comment #6
pdureau commentedfinally, we don't do footer_menu
Comment #7
pdureau commentedComment #9
pdureau commented