Problem/Motivation

After enabling and configuring Social PWA module push notifications are working from the test page: /admin/config/opensocial/pwa/notification.
But it doesn't work for on activity insert actions (for example after post on another user stream).

Proposed resolution

Replace $create_action->create($activity); with $create_action->process($activity); in the <code>activity_send_push_activity_insert() and remove deprecated code in PushActivitySend.php

CommentFileSizeAuthor
#3 activity_send_push_process-3414850-1.patch721 bytesgsa

Issue fork social_pwa-3414850

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ribel created an issue. See original summary.

ribel opened merge request !12

gsa’s picture

gsa commented
StatusFileSize
new activity_send_push_process-3414850-1.patch721 bytes

Providing a patch replacing $create_action->create($activity); with $create_action->process($activity); in activity_send_push.module.

ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Status: Active » Needs review
ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Issue summary: View changes

  • ribel committed 4a46a0a8 on 2.0.x 
    Issue #3414850: Fix web push notifications on activity insert

  • ribel committed 546ff68a on 2.1.x 
    Issue #3414850: Fix web push notifications on activity insert

ribel credited SV.

ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Version: 2.0.x-dev » 2.1.1
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.