Problem/Motivation

The PHP EOL dates in PhpRequirements.php can be incorrect.

Steps to reproduce

Proposed resolution

longwave suggested that a test could be added to to ensure that when a new PHP version is added to the CI matrix we are forced to add the EOL date to PhpRequirements.php

Remaining tasks

MR
Review

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3414184

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Normal » Major

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

longwave made their first commit to this issue’s fork.

longwave opened merge request !14516

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

This will pass on 8.3 and fail on 8.4/8.5 at present.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Seems to fail for 8.3 unit tests also.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

That seems to be an unrelated failure at github.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

#3569877: Add PHP 8.4 and 8.5 end of life dates to PhpRequirements landed so this should work now.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

It looks good to me. It's nice that we had a demonstration of a failing test prior to the inclusion of the EoL date for 8.5.

catch closed merge request !14516

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 5caa0819 on main 
    task: #3414184 Test that the PHP versions in .gitlab-ci.yml match PHP...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.