Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.While debugging accessCheck issues on a newly upgraded D10 site (from D9) I noticed this module's src/form/DmbNotificationTypeDeleteConfirm.php contains an accessCheck without setting "TRUE" or "FALSE". I did use Upgrade Status but it somehow did not catch this one.
I believe it should be set to TRUE, based on there being an accessCheck in this file. I have attached a patch.
I marked this as a Task (not a Bug) because I'm unsure what (if any) issues this causes, but it should probably be changed.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 34113526-accesscheck-not-set-notificationservice.patch | 550 bytes | caspervoogt |
| #2 | 3413526-accesscheck-not-set.patch | 637 bytes | caspervoogt |
Comments
Comment #2
caspervoogt commentedComment #4
mojiferousThanks for the find! That would definitely throw an error in D10, so I have added your patch and made a new release
Comment #5
caspervoogt commentedComment #6
caspervoogt commentedComment #7
caspervoogt commentedI missed one: src/Service/DmbNotificationService.php also has an empty access check.
Comment #8
caspervoogt commentedignore this patch
Comment #10
mojiferousCommitted and added a release for that as well
Comment #11
caspervoogt commentedComment #12
caspervoogt commentedComment #13
caspervoogt commentedignore 34113526-accesscheck-not-set-service.patch and use 34113526-accesscheck-not-set-notificationservice.patch instead pls
Comment #14
caspervoogt commentedThis is actually fine. I forgot that it is set to true by default so I was making much ado about nothing.