Problem/Motivation

After #3410312: Flood database backend ::isAllowed() should call ::ensureTableExists(), FunctionalJavaScript tests are the last to finish after FunctionalTests and KernelTests, we can decrease the run time by marking one more tests with @group #slow.

Drupal\Tests\options\FunctionalJavascript\OptionsFieldUITest

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3410452

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Title: Add @group #slow to more OptionsFieldUiTest » Add @group #slow to OptionsFieldUiTest
catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !5933

catch’s picture

catch
he/him
Primary language English
commented

Seven minutes and thirty four seconds: https://git.drupalcode.org/project/drupal/-/pipelines/67316

catch’s picture

catch
he/him
Primary language English
commented
Title: Add @group #slow to OptionsFieldUiTest » Add @group #slow to more tests

Adding a couple more that end up at the end of the test run once this is tagged and have 5-7 test methods each.

catch’s picture

catch
he/him
Primary language English
commented

7m39s after a handful more changes. Once you tag one or two tests, the distribution between the runners changes, and medium-slow tests that would have started at the beginning of one run end up near the end of another, and then run over.

Most of the functional and functional javascript test runs (not the whole jobs, just the actual run-tests.sh bit) are finishing in 3-4 minutes quite consistently now.

https://git.drupalcode.org/project/drupal/-/pipelines/67450

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

LGTM!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

#3410396: Add @group slow to ForumTest, HelpTopicSearchTest, ModulesListFormWebTest went first so have ignored those changes here.

Committed and pushed 4cc502ffa1 to 11.x and dd59d52105 to 10.2.x. Thanks!

  • longwave committed dd59d521 on 10.2.x 
    Issue #3410452 by catch: Add @group #slow to more tests

(cherry picked...

  • longwave committed 4cc502ff on 11.x 
    Issue #3410452 by catch: Add @group #slow to more tests

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.