Several improvements required for the Hero component

* Render mp4 and webm videos in Hero
* Improve support for "crimson" (bg-dark) option in Hero banner slot.
* Disallow "crimson" background color option when used outside of the banner slot in Sections paragraphs.
* Avoid multiple H1s on Page when page already has an H1 in the Hero banner (see sister ticket #3409566: Avoid multiple H1s when page has Hero banner).

Issue fork iu_paragraphs-3409056

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yasminOrj created an issue. See original summary.

yasminorj’s picture

yasminorj commented
Issue summary: View changes

Ability to add one of three different types of featured content in place of the banner:

If one of these types is present on a node, then the heading text should use an H1 and the normal page title block should use an H2.

yasminorj’s picture

yasminorj commented
Issue summary: View changes
yasminorj’s picture

yasminorj commented
Title: Rivet - Ability to add Hero/Billboard/CTA component on a node in Featured theme region » Rivet - Ability to add Hero/Billboard/CTA
Issue summary: View changes
yasminorj’s picture

yasminorj commented
Issue summary: View changes

jwilson3 made their first commit to this issue’s fork.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

Fixed here https://git.drupalcode.org/project/rivet/-/commit/2b684d3b47b2593a0689a7...

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Active » Fixed
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Fixed » Active
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Title: Rivet - Ability to add Hero/Billboard/CTA » Rivet - Avoid multiple H1s when page has Hero banner
Issue summary: View changes

jwilson3 opened merge request !20

  • jwilson3 committed 3c02b7e1 on 2.2.x 
    Issue #3409056 by yasminOrj, jwilson3: Rivet - Hero banner improvements
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Active » Fixed

  • jwilson3 committed c0116e22 on 2.2.x 
    Issue #3409056 by jwilson3: Rivet - Hero banner improvements

  • jwilson3 committed fd9c473d on 2.2.x 
    Issue #3409056 by jwilson3: Rivet - Hero banner improvements
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Title: Rivet - Avoid multiple H1s when page has Hero banner » Rivet - Hero banner improvements
Issue summary: View changes

  • jwilson3 committed 16267aba on 2.2.x 
    Issue #3409056 by jwilson3: Style hero component when in 'Sections' slot

  • jwilson3 committed d83d7e92 on 2.2.x 
    Issue #3409056 by jwilson3: Simplify secondary hero button style

  • jwilson3 committed 56c5632b on 2.2.x 
    Issue #3409056 by jwilson3: Use h1 in Hero only when in banner slot on...

  • jwilson3 committed ecf98844 on 2.2.x 
    Issue #3409056 by jwilson3: Avoid empty divs for missing fields in hero

  • jwilson3 committed dc9ccbf0 on 2.2.x 
    Issue #3409056 by jwilson3: Render mp4 and webm videos in Hero

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.