Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork hux-3408433

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: Unassigned » dpi
dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: +#3391860: ServiceClosureArgument with private service references original non-existent service

This issue blocks privatization of hooks services.

Its still not possible to use the MR with private hooks services!

dpi opened merge request !24

dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: dpi » Unassigned
Status: Active » Needs review

Green. But blocked on #3302312: Removing a Hux hook implementation/class can cause fatal errors

dpi’s picture

dpi
Location Perth, Australia
commented

  • dpi committed 69d12340 on 1.2.x 
    Issue #3408433 by dpi: Use a service locator to group hooks services...
dpi’s picture

dpi
Location Perth, Australia
commented
Version: 1.2.x-dev » 1.3.x-dev
Status: Needs review » Fixed

  • dpi committed 69d12340 on 1.x 
    Issue #3408433 by dpi: Use a service locator to group hooks services...
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Fixed » Active
Related issues: +#3408433: Use a service locator to group hooks services together to ease future privatization and lazy loading

Looks like this issue has trouble in 10.x series during `drush deploy` unless a patch from #3108020: Support ServiceClosureArgument in \Drupal\Component\DependencyInjection\Dumper\OptimizedPhpArrayDumper::dumpValue (D11 only) is also used.

Without it, on D10.x:

./bin/drush -r /data/app deploy -y
In OptimizedPhpArrayDumper.php line 440:
Unable to dump a service container if a parameter is an object without _serviceId.

I'll be pulling this changeset out of 1.3 and pushing into a Drupal 11 only branch.

  • dpi committed 28117e64 on 1.3.x 
    Revert "Issue #3408433 by dpi: Use a service locator to group hooks...

  • dpi committed 28117e64 on 1.x 
    Revert "Issue #3408433 by dpi: Use a service locator to group hooks...
dpi’s picture

dpi
Location Perth, Australia
commented
Version: 1.3.x-dev » 1.5.x-dev
Status: Active » Fixed

Can be found in 1.5.x and later.

dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: -#3408433: Use a service locator to group hooks services together to ease future privatization and lazy loading +#3347144: Form API #states property/states should use .once() to apply its rules (Can cause failures with BigPipe and possibly other situations)
dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: -#3347144: Form API #states property/states should use .once() to apply its rules (Can cause failures with BigPipe and possibly other situations) +#3108020: Support ServiceClosureArgument in \Drupal\Component\DependencyInjection\Dumper\OptimizedPhpArrayDumper::dumpValue

try again...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Closed (fixed) » Active

So the core stuff should be in 10.2 despite it not saying as much in #3108020: Support ServiceClosureArgument in \Drupal\Component\DependencyInjection\Dumper\OptimizedPhpArrayDumper::dumpValue.

dpi opened merge request !26

dpi’s picture

dpi
Location Perth, Australia
commented
Version: 1.5.x-dev » 1.4.x-dev

  • dpi committed 8942e6c6 on 1.4.x 
    Issue #3408433 by dpi: Use a service locator to group hooks services...
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Fixed

  • dpi committed 8942e6c6 on 1.x 
    Issue #3408433 by dpi: Use a service locator to group hooks services...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.