Problem/Motivation

  • Comply with Drupal coding standards (phpcs)

Issue fork facade-3408386

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !38

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Comply with Drupal coding standards (phpcs) » Comply with Drupal coding standards (3) (phpcs)
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@xiaohua-guan

Thank you for the refactoring. Can you please rebase the patch? Thanks!

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Please take a look again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. I'll merge the patch to 1.0.x, and close this issue as Fixed.

  • yas committed d2ff875c on 1.0.x authored by Xiaohua Guan 
    Issue #3408386 by Xiaohua Guan, yas: Comply with Drupal coding standards...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.