Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
#3400791: Update CKEditor 5 to 40.1.0 already landed in 10.2.x 👍
https://github.com/ckeditor/ckeditor5/releases/tag/v40.2.0 will appear NEXT WEEK (the week of 10.2.0)
Nightly changelog that will not change much anymore: https://github.com/ckeditor/ckeditor5/issues/14724
Changelog: https://github.com/ckeditor/ckeditor5/releases/tag/v40.2.0
Fixes include:
- #3376167: [upstream] [GHS] Add style to anchor leads to unusable behavior
- #3385566: [GHS] Test coverage for using CKEditor 5's "Source Editing" with a <template> tag
- (not reported by Drupal users, so no Drupal issue)
paste-from-office: Content from Word documents should be pasted correctly (without HTML styles tag content) on Windows systems. Closes #15333, #9002. (commit)
Features include:
link: Links can now be applied by pasting a URL on selected text. Closes #5656. (commit)
Proposed resolution
- Update
core/package.json yarn --cwd core install && yarn --cwd core build && yarn --cwd core build:ckeditor5-types
Remaining tasks
TBD
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
CKEditor 5 has been updated to 40.2.0.
Issue fork drupal-3406732
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
wim leersThis will fix
… but it currently results in
ImageUrlTestfailing, due to a BC break. See #3379104-29: Add a "CKEditor 5 nightly" GitLab CI job. The CKEditor 5 team is aware and is investigating. (It likely is a trivial fix: a missing dependency declaration on our side causing incorrect plugin loading order, or just a missing configuration entry.)Comment #3
wim leersComment #4
longwaveThis can be worked on now and hopefully we can land it in 10.2.0: https://github.com/ckeditor/ckeditor5/releases/tag/v40.2.0
Comment #6
longwaveComment #7
wim leersThanks, @longwave! This should result in the same test failures I previously reported in #2. @lauriii told me he'd take a look 😊🥳 (he knows our
DrupalImageplugin best).Comment #8
wim leersAlso note that now there is an upgrade guide available, which was not available yet last week: https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-40.... — that might help @lauriii.
Comment #9
longwaveAs expected, needs work for fails in
ImageUrlTest.Comment #11
lauriiiTests are passing. I think we could potentially get rid of the
DrupalInsertImagesince it isn't doing anything at the moment. This could be disruptive because we need to update existing config, but there could be also code referring to the toolbar button, e.g. other plugins could depend on it with a condition. I don't think we should block the update with that.Comment #12
wim leersThe changes look solid. Thank you so much, @lauriii! 🙏
Two observations:
DrupalInsertImagearound as an empty shell right in the code that is being modified indrupalinsertimage.js. (I was going to say: let's mark it for removal in Drupal 11, but that will then still be a contrib ecosystem disruption then that we can avoid. The cost of keeping this around is negligible. And … who knows what other upstream breakages will happen in the future, and this would give us one more code execution point to insert work-arounds? 🙈)Comment #13
wim leersPerfect! 😊🙏
Comment #16
catchCommitted/pushed to 11.x and 10.2.x, thanks! Nice to get this one in. Do we need a follow-up to discuss DrupalInsertImage more?
I've updated the release notes for the version change.
Comment #17
wim leersI don't think so. But I defer to @lauriii.
Comment #18
lauriiiI don't think we need a follow-up. We could probably remove it but at the same time it could be helpful to have the plugin and the custom insert button already available in case that CKEditor team decides to make more BC breaking changes to their image insert button.