Problem/Motivation

Add a function to tests/src/Behat/features/bootstrap/FeatureContext.php to take a screenshot of a Form.

  • Output a screenshot of the form in png format.
  • Specify the URL as the file name.
  • To distinguish between the files output by the BDD test, output to the /form_screenshot directory.

Issue fork cloud-3406395

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !2130

sekinet’s picture

sekinet commented
Status: Active » Needs review

@yas

Could you please review the patch?

sekinet’s picture

sekinet commented
Issue summary: View changes
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@sekinet

I posted my comment, however I think we should refactor the existing code base at https://github.com/docomoinnovations/drupalextension/blob/6.x/src/Drupal...

Thanks!

sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas

Thank you for your comment. I have fixed it as you suggested. There is an error in phpstan, but it should go away once the PR#24 is merged. Could you please check?

sekinet’s picture

sekinet commented
Status: Needs review » Needs work
sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas

Fixed to output with I take screenshot. Refactoring has been done accordingly. Could you please check it?

baldwinlouie’s picture

baldwinlouie commented

@sekinet This is a great patch. It looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for your review.

@sekinet

Thank you for the patch. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 8fe2f723 on 6.x authored by sekinet 
    Issue #3406395 by sekinet, yas, baldwinlouie: Add a function to...

  • yas committed fff2f699 on 5.x authored by sekinet 
    Issue #3406395 by sekinet, yas, baldwinlouie: Add a function to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.