Problem/Motivation

  • Migrate to native JavaScript from jQuery (k8s_refresh_resource_trigger.js)

Issue fork cloud-3406159

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hosomitm created an issue. See original summary.

hosomitm opened merge request !2128

yas made their first commit to this issue’s fork.

hosomitm’s picture

hosomitm commented
Status: Active » Needs review

@yas

Please review the code. Thanks.

Note:
If you merge this Merge request, the argument will not be passed correctly to "updatedNodes" of k8s_node_heatmap.js. When refactoring k8s_node_heatmap.js, keep in mind that you need to make sure that the arguments are passed correctly from k8s_refresh_resource_trigger.js to updatedNodes in k8s_node_heatmap.js.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@hosomitm

Thank you for the refactoring. I posted my comment. Thanks!

hosomitm’s picture

hosomitm commented
Status: Needs work » Needs review

@yas

I have corrected the indicated source code.
Please review again.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@hosomitm

Thank you for the update. It looks good to me. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 3c44c9f7 on 6.x authored by hosomitm 
    Issue #3406159 by hosomitm, yas: Refactor to native JavaScript from...

  • yas committed dfc9b8bb on 5.x authored by hosomitm 
    Issue #3406159 by hosomitm, yas: Refactor to native JavaScript from...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue tags: +chatgpt

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.