Problem/Motivation

  • Migrate to native JavaScript from jQuery (aws_cloud_instance_monitor.js)

Issue fork cloud-3405792

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Masami created an issue. See original summary.

Masami opened merge request !2122

masami’s picture

masami commented
Title: Migrate to native JavaScript from jQuery (7) (aws_cloud_form.js) » Migrate to native JavaScript from jQuery (aws_cloud_instance_monitor.js )
Issue summary: View changes
Status: Active » Needs review

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Migrate to native JavaScript from jQuery (aws_cloud_instance_monitor.js ) » Refactor to native JavaScript from jQuery (aws_cloud_instance_monitor.js )
Issue summary: View changes
Status: Needs review » Needs work

@masami

Thank you for the refactoring. I posted my comments. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue tags: +chatgpt
masami’s picture

masami commented
Status: Needs work » Needs review

  • yas committed 243603af on 6.x authored by Masami 
    Issue #3405792 by Masami, yas: Refactor to native JavaScript from jQuery...

  • yas committed b11cc08a on 5.x authored by Masami 
    Issue #3405792 by Masami, yas: Refactor to native JavaScript from jQuery...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masmai

Sorry, I mistakenly merged the patch, however after that I found there is one place to be refactored for the if-conditions. Can you create the hotfix? Thanks!

Masami opened merge request !2167

Masami changed the visibility of the branch 3405792-hotfix to hidden.

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masami

Can you please check my comments? Thanks

masami’s picture

masami commented

@yas
Please check this PR
https://git.drupalcode.org/project/cloud/-/merge_requests/2167

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masami

Thank you for the MR. Can you please rebase it due to the previous merge? Thanks

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masami

Can you please rebase it due to the previous merge? Thanks

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed ffe80db7 on 6.x authored by Masami 
    Issue #3405792 by Masami, yas: Hotfix - Refactor to native JavaScript...

  • yas committed f10f8d4a on 5.x authored by Masami 
    Issue #3405792 by Masami, yas: Hotfix - Refactor to native JavaScript...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.