Problem/Motivation

Discovered whilst working on #3405696: Update composer dependencies for Drupal 10.2.0:

Looks like symfony/psr-http-message-bridge switched its semver 2.x schedule to the 6.x/7.x schedule of the main Symfony components.

Currently we have a constraint of ^2.1 on this dependency, which keeps it at 2.3.1 and doesn't allow an update to our (current) other SF ^6.4 components.

The code changes between 2.3.1 and 6.4.0 seem minimal.

Steps to reproduce

Proposed resolution

- Change the restriction on symfony/psr-http-message-bridge in core/composer.json from ^2.1 to allow both ^2.1 and ^6.4.
- $ composer update symfony/psr-http-message-bridge

Per @longwave in #5:

I think we should allow either version in composer.json for backward compatibility, but lock to the newer one as we are upgrading everything else to Symfony 6.4.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

The constraint for the dependency on symfony/psr-http-message-bridge now allows both ^2.1 as before and ^6.4 for backward compatibility. In the composer.lock the constraint ^6.4 is used, since all other Symfony components are upgraded to that version.

Issue fork drupal-3405704

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Spokje created an issue. See original summary.

spokje’s picture

Would love to have this in 10.2.0, but since it's technically a major version bump and thus not allowed I need some guidance here.

spokje’s picture

Status: Active » Needs review
longwave’s picture

I think we should allow either version in composer.json for backward compatibility, but lock to the newer one as we are upgrading everything else to Symfony 6.4. That way, core-recommended users get bumped to the latest version but people can fall back to the older one if something else has a hard requirement on it.

spokje’s picture

Issue summary: View changes

Thanks @longwave, didn't think of that.
Applied to the MR and updated the IS.

longwave’s picture

Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks. Bumping to critical as ideally this needs to land before 10.2.0.

  • catch committed 8070b9a1 on 10.2.x
    Issue #3405704 by Spokje, longwave: symfony/psr-http-message-bridge...

  • catch committed 8a9dce4b on 11.x
    Issue #3405704 by Spokje, longwave: symfony/psr-http-message-bridge...
catch’s picture

Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.