Problem/Motivation

The navidation bar is not rendering the menu to collapse some options and don't show all options, the layout limiter is explodiing and some menu options is hidden
This is an inconsistent bug and happen because the javascript try to built the menu before to render the navigation bar, when the navigation bar is rendered before the error don't happen.

Steps to reproduce

  • Go to a page with navigation bar with many options
  • Try to load the page and some times the navigation bar is not show all options

Proposed resolution

This problem already be faced and tried to fix envolving the function in a promise, but the error continue happen.
Change the promise by once function to avoid some undefined variables.

CommentFileSizeAuthor
#2 socialblue-navigation-bar-is-not-show-all-option-3405589-2.patch5.07 KBviniciusrp

Issue fork socialblue-3405589

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

viniciusrp created an issue. See original summary.

viniciusrp’s picture

viniciusrp commented
Status: Active » Needs review
StatusFileSize
new socialblue-navigation-bar-is-not-show-all-option-3405589-2.patch5.07 KB

I created a patch to fix it

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, setting as RTBC.

viniciusrp’s picture

viniciusrp commented
Version: 2.5.2 » 2.5.x-dev

viniciusrp opened merge request !127

  • viniciusrp committed a91731ec on 2.5.x 
    Issue #3405589: Navigation bar is not showing menu and explode the...
viniciusrp’s picture

viniciusrp commented
Assigned: Unassigned » viniciusrp
Status: Reviewed & tested by the community » Fixed

That fix was released at 2.5.5 version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.