Problem/Motivation

  • Refactor k8s_launch_template_source_type.js from jQuery to native JavaScript.
  • Delete k8s_launch_template_form.js that are no longer needed along with it.

Issue fork cloud-3405430

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !2121

sekinet’s picture

sekinet commented
Status: Active » Needs review

@yas

Could you please review the patch?

sekinet’s picture

sekinet commented
Status: Needs review » Reviewed & tested by the community

@yas @hosomitm
Thank you for providing the patch. It looks good to me. Because we don't need this JavaScript anymore.
Background.
Previously, source_type included yaml and added JavaScript to switch to the YAML tab when it was selected.
We have since refactored the source_type to remove the yaml from the source_type. However, I think we ware unable to remove this JavaScript file and the unnecessary file remained.
Thanks.

sekinet’s picture

sekinet commented
Status: Reviewed & tested by the community » Needs review

Sorry, the above comment was an error in commenting on another Issue. Please review the patch. Thanks.

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@sekinet

Thank you for the refactoring. Can you please create the patch for 5.x branch, too?

After that, I'll merge the patch to 5.x and 6.x, and close this issue as Fixed

sekinet opened merge request !2123

sekinet changed the visibility of the branch 3405430-refactor-to-native-JavaScript-from-jQuery-k8s_launch_template_source_type.js-5x to hidden.

sekinet opened merge request !2125

sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas

I have also created a patch for the 5.x branch. Could you please check it?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@sekinet

Thank you for supplying the patch for 5.x. I'll merge the patch to 5.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

  • yas committed 0884f436 on 5.x authored by sekinet 
    Issue #3405430 by sekinet, yas: Refactor to native JavaScript from...

  • yas committed d99fd526 on 6.x authored by sekinet 
    Issue #3405430 by sekinet, yas: Refactor to native JavaScript from...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue tags: +chatgpt

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.