Steps to reproduce

go to /taxonomy/term/foo/edit and tick/untick checkboxes and save in 10.1.6. the following appears on the next screen:

Deprecated function: Creation of dynamic property Drupal\permissions_by_term\Service\NodeAccess::$nodeAccessRecordFactory is deprecated in Drupal\permissions_by_term\Service\NodeAccess->__construct() (line 85 of modules/contrib/permissions_by_term/src/Service/NodeAccess.php).

Also saving a basic page content type with a taxonomy term that has permissions applied to it results in the same error being shown.

The changes still save, so this isn't a major issue.

I tried applying some of the needs review patches that mentioned deprecation, they either didn't apply anymore or didn't help with the issue.

Issue fork permissions_by_term-3403249

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

erutan created an issue. See original summary.

erutan’s picture

erutan commented
Title: Deprecated Function error when saving permissions changes » Deprecated Function error when saving permissions changes or page with permissions applied
Issue summary: View changes

chetan 11 made their first commit to this issue’s fork.

chetan 11 opened merge request !38

chetan 11’s picture

chetan 11 commented
Status: Active » Needs review

Hi,
I have fixed the above error on my local, please check the raised MR.
Thanks.

erutan’s picture

erutan commented
Status: Needs review » Reviewed & tested by the community

This fixes the error for me, thanks!

Rebased against the commit that came in since and it applies cleanly.

marcoliver made their first commit to this issue’s fork.

  • marcoliver committed f65a109f on 3.1.x-dev authored by chetan 11 
    Issue #3403249 by chetan 11, marcoliver, erutan: Deprecated Function...
marcoliver’s picture

marcoliver
he/him
Primary language German
Location Neuss, NRW, Germany
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Merged. Will tag a new release shortly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.