Problem/Motivation

There has been a regression: the styles for the active trail of parent of the active menu items have been lost.

Steps to reproduce

  • Navigate to /admin/structure/display-modes/form
  • Open the Structure menu and check the parent items of the menu don't have active styles (they should)

Proposed resolution

Get back the initial active styles. Figma designs: https://www.figma.com/file/fn52micITi1fCNtU0fWcPC/Prototype?type=design&...

CommentFileSizeAuthor
#2 active-trail.png39.82 KBckrina
active-trail.png30.79 KBckrina

Issue fork navigation-3402895

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ckrina created an issue. See original summary.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Issue summary: View changes
StatusFileSize
new active-trail.png39.82 KB

Adding link to designs.

kostyashupenko made their first commit to this issue’s fork.

kostyashupenko opened merge request !135

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Needs review
finnsky’s picture

finnsky commented

Probably better here use :has selector.

https://developer.mozilla.org/en-US/docs/Web/CSS/:has

is is mostly in Firefox

For now only maybe some polyfill can be attached?

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented

Firefox 121 is the current Beta version of Firefox and ships on December 19, 2023.

I'd say as long as we include proper instructions to test this on Firefox (or at least to say to test this in Chrome), I'm sure Firefox 121 will be released before we have an initial alpha release :)

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Needs work

I forgot to move it to NW to address @finnsky's suggestion :)

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Needs work » Needs review
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community

finnsky’s picture

finnsky commented
finnsky’s picture

finnsky commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.