Document Scripts [#3401807]

Problem/Motivation

Current scripts have simple comments inside.
Custom events should be described globally.

Proposed resolution

Add core style javascript documentation:
https://www.drupal.org/docs/develop/standards/javascript-coding-standard...

Issue fork navigation-3401807

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3401807-document-scripts changes, plain diff MR !147
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

15 November 2023 at 10:30

finnsky created an issue. See original summary.

Comment #2

8 December 2023 at 04:37

Meeni_Dhobale made their first commit to this issue’s fork.

Comment #3

11 December 2023 at 10:24

Meeni_Dhobale opened merge request !147

Comment #4

meeni_dhobale commented 11 December 2023 at 10:36

Status:

Active

» Needs review

I raised the MR by adding some comments and tags where needed. I also followed the javascript coding standards as well.

while checking for the linting errors I found one.

modules/contrib/navigation/js/toolbar-popover.js
  102:15  error  'close' was used before it was defined  no-use-before-define

✖ 1 problem (1 error, 0 warnings)

the same error shown by the delayedClose() as well, So I moved it upwards before the close() and open() functions, but inside he delayedClose() the close() is called. So here circular deadlock occurs.
Is there any solution to solve this.