Problem/Motivation

When using the scale effect after the manual crop with automatic provider.. the scale effect just seems to add black background around the cropped area instead of scaling the cropped area to the appropriate size.

Steps to reproduce

Create an image style
Use manual crop effect with Automatic crop provider selected
Add a scale effect after.
Do not select allow upscaling

Proposed resolution

Unsure yet if this a bug with automatic crop or with the core scale effect OR just that my source image is too small to support the scale effect.

CommentFileSizeAuthor
#3 palm.jpeg12.39 KBpieter.vanhove
#3 palm1.jpeg30.98 KBpieter.vanhove
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rosemaryreilman created an issue. See original summary.

rosemaryreilman’s picture

Status: Active » Closed (outdated)

Closing. This doesn't seem to be an issue anymore.

pieter.vanhove’s picture

StatusFileSize
new30.98 KB
new12.39 KB

I'm still getting this issue for images that are smaller than the crop size. Settings per this article: https://interactiveknowledge.com/insights/how-use-automated-crop-module

Selected image: 275 × 183

Crop type: Landscape (3:1)
Aspect Ratio: 3:1
Soft limit: 1440×480
No hard limit.

Image style:
Crop type: Landscape (3:1)
Automatic crop provider: Automated crop

It seems that the automated crop is simply not applied for these images. When i set the crop manually everything works as expected. For images that are at least the specified soft limit in size, everything seems to work as well.

pieter.vanhove’s picture

Status: Closed (outdated) » Active
rosemaryreilman’s picture

Version: 3.x-dev » 4.x-dev

Thanks for reopening and reporting. We will take a look as soon as we can.

rosemaryreilman’s picture

Status: Active » Needs review

Please see the merge request I created..and patch the module with it. I was able to recreate the issue you are seeing and I believe I resolved it. Thanks!

rosemaryreilman’s picture

Assigned: Unassigned » rosemaryreilman
rosemaryreilman’s picture

Title: Potential bug when using Scale effect » Potential bug when using Scale effect and/or Soft Limits Set

  • rosemaryreilman committed 11d14dd7 on 4.x
    Issue #3401213 by rosemaryreilman: Potential bug when using Scale effect...
rosemaryreilman’s picture

Status: Needs review » Fixed

Went ahead and added this to new release 4.0.0 after testing on a couple of our sites. Please reopen if necessary.

rosemaryreilman’s picture

Status: Fixed » Closed (fixed)