Problem/Motivation
When using the scale effect after the manual crop with automatic provider.. the scale effect just seems to add black background around the cropped area instead of scaling the cropped area to the appropriate size.
Steps to reproduce
Create an image style
Use manual crop effect with Automatic crop provider selected
Add a scale effect after.
Do not select allow upscaling
Proposed resolution
Unsure yet if this a bug with automatic crop or with the core scale effect OR just that my source image is too small to support the scale effect.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | palm.jpeg | 12.39 KB | pieter.vanhove |
| #3 | palm1.jpeg | 30.98 KB | pieter.vanhove |
Issue fork automated_crop-3401213
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
rosemaryreilmanClosing. This doesn't seem to be an issue anymore.
Comment #3
pieter.vanhove commentedI'm still getting this issue for images that are smaller than the crop size. Settings per this article: https://interactiveknowledge.com/insights/how-use-automated-crop-module
Selected image: 275 × 183
Crop type: Landscape (3:1)
Aspect Ratio: 3:1
Soft limit: 1440×480
No hard limit.
Image style:
Crop type: Landscape (3:1)
Automatic crop provider: Automated crop
It seems that the automated crop is simply not applied for these images. When i set the crop manually everything works as expected. For images that are at least the specified soft limit in size, everything seems to work as well.
Comment #4
pieter.vanhove commentedComment #5
rosemaryreilmanThanks for reopening and reporting. We will take a look as soon as we can.
Comment #7
rosemaryreilmanPlease see the merge request I created..and patch the module with it. I was able to recreate the issue you are seeing and I believe I resolved it. Thanks!
Comment #8
rosemaryreilmanComment #9
rosemaryreilmanComment #11
rosemaryreilmanWent ahead and added this to new release 4.0.0 after testing on a couple of our sites. Please reopen if necessary.
Comment #12
rosemaryreilman