Problem/Motivation

The output of the nightwatch test job on GitLab are currently not saved as artifacts.

Steps to reproduce

Compare the artifacts of nightwatch on a recent DrupalCI run (for example https://dispatcher.drupalci.org/job/drupal8_core_regression_tests/88034/...) with the artifacts of a recent GitLab run (for example https://git.drupalcode.org/project/drupal/-/jobs/316331/artifacts/browse...)

Proposed resolution

Preserve the artifacts of a nightwatch run
Artifacts for nightwatch from this MR: https://git.drupalcode.org/issue/drupal-3401102/-/jobs/323652/artifacts/...

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3401102

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Title: Nightwatch artifacvts on GitLab not retained » Nightwatch artifacts on GitLab not retained

Spokje opened merge request !5361

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems fine to me.

Would love to know why nightwatch is failing so frequently in gitlab this last week.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs review

Should we set DRUPAL_NIGHTWATCH_OUTPUT to ../nightwatch_output instead? Feels a bit wrong writing inside the core directory, which is part of the checkout.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

Sure, just wanted to maintain the original setting of DRUPAL_NIGHTWATCH_OUTPUT.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

Question about the mkdir/chown lines - not sure these are needed even if it's working without it!

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
spokje’s picture

spokje
Primary language Dutch
commented

I think we lost babel, along with its caching somewhere around #3278415: Remove usages of the JavaScript ES6 build step, the build step itself, and associated dev dependencies?

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje
Status: Needs review » Needs work
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Needs work » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje
Status: Needs review » Needs work
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Needs work » Needs review

This seems to be the minimal mkdir-s that would be otherwise created through Drupal and the minimal chown-s to work/prevent warnings.

To my surprise running yarn as root doesn't work. It isn't able to create directories under sites no matter what I chown/chmod _shrugs_

spokje’s picture

spokje
Primary language Dutch
commented

Well, I stand corrected, all mkdir-s are not needed.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Leaning on this didn't break anything it seems and am seeing artifacts here https://git.drupalcode.org/issue/drupal-3401102/-/jobs/335835/artifacts/...

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Also seeing Nightwatch results now at https://git.drupalcode.org/issue/drupal-3401102/-/pipelines/50024/test_r...

Great work!

  • longwave committed b71596d0 on 10.2.x 
    Issue #3401102 by Spokje, longwave, smustgrave: Nightwatch artifacts on...

  • longwave committed 93eb2340 on 11.x 
    Issue #3401102 by Spokje, longwave, smustgrave: Nightwatch artifacts on...

  • longwave committed 5e1bfe3a on 10.1.x 
    Issue #3401102 by Spokje, longwave, smustgrave: Nightwatch artifacts on...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 93eb23400e to 11.x and b71596d090 to 10.2.x. Thanks!

I wasn't expecting it to backport cleanly to 10.1.x, but it did, so cherry-picked it there too.

Spokje closed merge request !5361

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.