Problem/Motivation

Currently, CSS Grid Layout is supported by all browsers and allows more freedom in layouts.

In the current sidebar we use conditions and cascades for what CSS Grid Layout does out of the box.
Also usage of block margin not recommended by BEM:
https://en.bem.info/methodology/css/#external-geometry-and-positioning
It is job of parent block.

In MR I added CSS Grid for the content of the sidebar and toolbar block.

I also removed unnecessary margin paddings at the opening and closing. There is no need for them at all.

No or minimal visual changes. The code is much simpler.

Issue fork navigation-3397952

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

finnsky created an issue. See original summary.

finnsky opened merge request !120

finnsky’s picture

finnsky commented
Assigned: finnsky » Unassigned
Status: Active » Needs review
finnsky’s picture

finnsky commented
Issue summary: View changes

  • finnsky committed 1bbdb75b on 1.x 
    Simplify the grid. Small improvement - #3397952
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Fixed

Thanks Ivan! It makes a lot of sense. Merging it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.