Problem/Motivation

Currently it catched in
https://www.drupal.org/project/navigation/issues/3392875
When new Navigation or current Toolbar expanded
.container style of Umami theme ignores it

Steps to reproduce

Login as admin and set toolbar to vertical mode. Or enable new Navigation module.

Proposed resolution

Add variable calculation to container max-width.

CommentFileSizeAuthor
#5 Screenshot 2023-10-30 at 1.12.14 PM.png675.49 KBsmustgrave
#5 Screenshot 2023-10-30 at 1.11.36 PM.png2.23 MBsmustgrave

Issue fork drupal-3397532

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

finnsky created an issue. See original summary.

finnsky opened merge request !5174

finnsky’s picture

finnsky commented
Status: Active » Needs review
finnsky’s picture

finnsky commented
Title: Fix Umami container paddings when toolbar or navigation expanded. » Fix Umami container max-width when toolbar or navigation expanded.
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot 2023-10-30 at 1.11.36 PM.png2.23 MB
new Screenshot 2023-10-30 at 1.12.14 PM.png675.49 KB

before

before

After

after

So the MR does fix the issue but also has made the main column narrower.

finnsky’s picture

finnsky commented

Re #5

Seems large screen also needs media query ;)

finnsky’s picture

finnsky commented
Status: Needs work » Needs review

Fixed both feedbacks.
Please review!

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

My concern has been addressed. Change looks good.

quietone’s picture

quietone commented

I'm triaging RTBC issues. I read the IS and the comments. I didn't find any unanswered questions or other work to do.

Leaving at RTBC.

  • nod_ committed 16b96ada on 11.x 
    Issue #3397532 by finnsky, smustgrave, markconroy: Fix Umami container...

  • nod_ committed 21ef7ddb on 10.3.x 
    Issue #3397532 by finnsky, smustgrave, markconroy: Fix Umami container...

nod_ credited markconroy.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 16b96ad and pushed to 11.x. Thanks!

quietone closed merge request !5174

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.