Problem/Motivation

Lets see if Gitlab CI does not or can be convinced not to get confused about our lightning integration, so we could have tests running again.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork bynder-3396594

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Berdir created an issue. See original summary.

mohd sahzad’s picture

mohd sahzad commented
Assigned: Unassigned » mohd sahzad

Mohd Sahzad opened merge request !23

mohd sahzad’s picture

mohd sahzad commented
Assigned: mohd sahzad » Unassigned
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

I'm not sure why this uses a custom gitlab-ci.yml. It should start with the template documented on https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

sahana _n’s picture

sahana _n commented
Assigned: Unassigned » sahana _n
sahana _n’s picture

sahana _n commented
Assigned: sahana _n » Unassigned
Status: Needs work » Needs review

Please review My MR.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Tests are running, that's great. Now there are two tests that need to be fixed, starterkit_theme should be used instead of classy and the other test creates a role that needs a name.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Fixed

Fixed the tests, merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.