I'm not sure if anyone has looked into this, but would it be an idea to make 8.x-1.x compatible with D10? 2.2.x is dependent on OIDC 3.x, which is far from having a stable release. OIDC 8.x-1.x is now D10 (https://www.drupal.org/project/openid_connect/issues/3393666) compatible so that we could upgrade sites dependent on this module.

CommentFileSizeAuthor
#2 issue-3395622.patch2.81 KBgogowitsch

Comments

mnlund created an issue. See original summary.

gogowitsch’s picture

gogowitsch commented
Issue tags: +D10 compatibility
StatusFileSize
new issue-3395622.patch2.81 KB

I have tested this module with Drupal v10.0.0 and v10.1.6. The dependency openid_connect was at v1.4.0.

Please review the attached patch. It applies to both the 8.x-1.x branch and the 8.x-1.7 tag and is needed to run this module under Drupal 10.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Oh, nice! That was not yet a thing when we started on the 2.2.x version to support openid_connect v3

Although the 2.2.x version is getting there, I have no objections at all to make the 8.x branch D10 compatible.

@mnlund if you could test the patch here that would be much appreciated!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

looks good!

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Fixed

Committed! Will tag a new release in a bit and update the project description.

mnlund’s picture

mnlund commented

Great stuff! Patch seems to be working just fine. Thank you for following up.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Tagged release 8.x-1.8

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.