Problem/Motivation

The Attach Libraries component autocomplete feature doesn't work with Site Studio 7.0.

Steps to reproduce

  1. Install site using Site Studio 7
  2. Install Site Studio Extras
  3. Add Attach Libraries component to a component
  4. Search for a library
CommentFileSizeAuthor
#3 3394995-03.patch1.65 KBkevinfunk

Issue fork sitestudio_extras-3394995

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kevinfunk created an issue. See original summary.

kevinfunk’s picture

kevinfunk
he/him
commented
Status: Active » Needs review
kevinfunk’s picture

kevinfunk
he/him
commented
StatusFileSize
new 3394995-03.patch1.65 KB

Uploading a patch for testing.

kevinfunk opened merge request !2

mandclu’s picture

mandclu commented
Status: Needs review » Reviewed & tested by the community

I was seeing a large number of ugly errors thrown related to jQueru UI Autocomplete not being found. The provided patch fixed it.

That said, if this fix is really for Site Studio 7 and newer, should the patch also declare a dependency on this version? At that point, would it make more sense to target a new minor version, or maybe even a new major version of this module for the change?

kevinfunk’s picture

kevinfunk
he/him
commented
Status: Reviewed & tested by the community » Needs review

Good call @mandclu. I've update the MR to require Site Studio 7.

  • mandclu committed 56873803 on 1.0.x authored by kevinfunk 
    Issue #3394995 by kevinfunk: Attach Libraries autocomplete doesn't work...
mandclu’s picture

mandclu commented
Status: Needs review » Fixed

Based on some feedback outside this thread, I'm going to call this RTBC. As such, the changes have been merged in.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.