Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Error
TypeError: Drupal\tfa\Form\TfaDisableForm::deleteUserData(): Argument #2 ($key) must be of type string, null given, called in /var/www/html/web/modules/custom/tfa/src/Form/TfaDisableForm.php
Steps to reproduce
As admin navigate to user/USER_ID_HERE/security/tfa/disable for a user with TFA enabled, attempt to disable TFA and receive an error.
This is suspected to be related to some of our recent typehint changes.
Proposed resolution
Remaining tasks
User interface changes
None
API changes
None expected
Data model changes
None
Issue fork tfa-3393468
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
sarwan_verma commentedComment #4
sarwan_verma commentedHi @cmlara,
I have fixed the issue in MR, please review and verify.
Comment #5
cmlaraAdded comments in the MR, setting back to NW for their resolution.
Comment #6
sarwan_verma commentedComment #7
sarwan_verma commentedHi @cmlara,
Please share the reproduce steps, i'm not able to clone this module on my local.
Comment #8
cmlaraI'm wondering if I'm not understanding your response, are you attempting to resolve issues without having the module installed?
If you mean reproducing the MR comments, part of reproducing is from Human Review, and the other is from PHPStan which can be tested with
phpstan analyze ./from the modules directory (this does require downloading the module into a development lab), we also include the results in our GitLab CI tests.If you mean reproducing the bug, the (high level) steps are included in the Issue Summary, reproducing does require having the module installed to test.
Comment #9
bhanu951 commentedGot hit by this issue, when trying to fix #3395254: Wrong domain name for Google Authenticator on TOTP and HOTP setup page on dev branch.
Can confirm, patch resolves the issue.
But seems PHPDoc Block type hint is not updated to match the variable type ?
Comment #10
bhanu951 commentedSeems @cmlara already commented on the issue, I updated the PHPDoc block.
Comment #11
bhanu951 commentedAddressed review comments, please re review.
Comment #13
cmlaraLGTM, merged to dev. Thank you!