Problem/Motivation
The DSFR library is now removed from the ui_suite_dsfr source code and should be added/required through another manner.
The current code in 1.0-beta4 currently relies on a composer repository package defined the module composer.json. It contains a requirement to this defined package with the exact same non-standard name "gouvfr/dsfr".
this may not be the best way to achieve the requirement of DSFR, and this does not let people choose their way of including the library (for example using asset-packagist or another method...)
Steps to reproduce
Proposed resolution
Let's look at and iter over the different possible options and eventually move to another solution for its integration?
the corresponding documentation and clarifications would be necessary i guess.
I am open and available to contribute on this issue.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | ui_suite_dsfr-dsfr_integration-3392854-3.patch | 411 bytes | just_like_good_vibes |
Issue fork ui_suite_dsfr-3392854
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
just_like_good_vibesComment #3
just_like_good_vibesHello,
because the current code in 1.0-beta4 simply breaks the download of ui_suite_dsfr via composer (unless you add the package repository to the 'root' composer.json),
i propose first to drop the requirement at the heart of the problem. Here is a one line patch to starts with.
Comment #5
pdureau commentedComment #7
pdureau commentedComment #9
just_like_good_vibesHello,
i updated the README of the project to include an install section.
see MR 37.
Comment #10
pdureau commentedthanks, i will have a look
Comment #11
pdureau commentedHello @just_like_good_vibes
Sorry for the delay, I was busy on other tasks. I am having a look now, and I will release the beta5 soon.
Comment #13
pdureau commentedComment #14
just_like_good_vibesthank you Pierre, all the best
Comment #15
pdureau commentedComment #16
pdureau commentedComment #17
pdureau commented