Problem/Motivation

The DSFR library is now removed from the ui_suite_dsfr source code and should be added/required through another manner.
The current code in 1.0-beta4 currently relies on a composer repository package defined the module composer.json. It contains a requirement to this defined package with the exact same non-standard name "gouvfr/dsfr".
this may not be the best way to achieve the requirement of DSFR, and this does not let people choose their way of including the library (for example using asset-packagist or another method...)

Steps to reproduce

Proposed resolution

Let's look at and iter over the different possible options and eventually move to another solution for its integration?
the corresponding documentation and clarifications would be necessary i guess.

I am open and available to contribute on this issue.

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

just_like_good_vibes created an issue. See original summary.

just_like_good_vibes’s picture

just_like_good_vibes’s picture

Hello,
because the current code in 1.0-beta4 simply breaks the download of ui_suite_dsfr via composer (unless you add the package repository to the 'root' composer.json),
i propose first to drop the requirement at the heart of the problem. Here is a one line patch to starts with.

pdureau’s picture

Title: Change/review the way the DSFR library is integrated and required » [beta5] Change/review the way the DSFR library is integrated and required

pdureau’s picture

Status: Active » Fixed

just_like_good_vibes’s picture

Hello,
i updated the README of the project to include an install section.
see MR 37.

pdureau’s picture

Assigned: just_like_good_vibes » pdureau
Status: Fixed » Needs review

thanks, i will have a look

pdureau’s picture

Hello @just_like_good_vibes

Sorry for the delay, I was busy on other tasks. I am having a look now, and I will release the beta5 soon.

pdureau’s picture

Status: Needs review » Reviewed & tested by the community
just_like_good_vibes’s picture

thank you Pierre, all the best

pdureau’s picture

Status: Reviewed & tested by the community » Fixed
pdureau’s picture

Assigned: pdureau » Unassigned
pdureau’s picture

Status: Fixed » Closed (fixed)