Problem/Motivation

There are some minor issues drupal-check found.

Steps to reproduce

$ vendor/bin/drupal-check --drupal-root $CI_PROJECT_DIR/$_WEB_ROOT $CI_PROJECT_DIR/$_WEB_ROOT/modules/custom/$CI_PROJECT_NAME
  0/34 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   0%
 34/34 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
 ------ ----------------------------------------------------------------------- 
  Line   tests/src/Unit/AccessControlHandlerTest.php                            
 ------ ----------------------------------------------------------------------- 
  96     Class Drupal\moderation_note\AccessControlHandler constructor invoked  
         with 4 parameters, 1 required.                                         
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------- 
  Line   tests/src/Unit/Service/MenuCountServiceTest.php                  
 ------ ----------------------------------------------------------------- 
  90     Call to an undefined method                                      
         Prophecy\Prophecy\ObjectProphecy<Drupal\Core\Url>::fromRoute().  
  143    Call to an undefined method                                      
         Prophecy\Prophecy\ObjectProphecy<Drupal\Core\Url>::fromRoute().  
  196    Call to an undefined method                                      
         Prophecy\Prophecy\ObjectProphecy<Drupal\Core\Url>::fromRoute().  
  248    Call to an undefined method                                      
         Prophecy\Prophecy\ObjectProphecy<Drupal\Core\Url>::fromRoute().  
  298    Call to an undefined method                                      
         Prophecy\Prophecy\ObjectProphecy<Drupal\Core\Url>::fromRoute().  
  348    Call to an undefined method                                      
         Prophecy\Prophecy\ObjectProphecy<Drupal\Core\Url>::fromRoute().  
 ------ ----------------------------------------------------------------- 
 [ERROR] Found 7 errors                                                         
Thanks for using drupal-check!

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork moderation_note-3392022

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bluegeek9 created an issue. See original summary.

bluegeek9 opened merge request !36

bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned
Issue summary: View changes

bluegeek9 opened merge request !38

  • bluegeek9 committed 393cae34 on 8.x-1.x 
    Issue #3392022 by bluegeek9: drupal-check suggestions
bluegeek9’s picture

bluegeek9 commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.