Issue fork geo_entity-3391749

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

millnut created an issue. See original summary.

millnut opened merge request !6

millnut’s picture

millnut commented
Issue summary: View changes
Status: Active » Needs review
millnut’s picture

millnut commented

Ignore composer require failures, I didn't realise that is from DrupalCI manual runs. The GitLab CI pipeline passes with warnings on phpcs and eslint.

Those warnings I can pick up once the gitlabci file is merged in.

millnut’s picture

millnut commented
Status: Needs review » Active

Changed to "Active" as I want to look into getting a matrix setup to test against both PHP 8.1 and 8.2 and hard fail coding standards so it matches the github workflow.

millnut’s picture

millnut commented
Status: Active » Needs review

Ready for review; phpcs fails due to coding standards issues; and similar warning for eslint but that is currently set to warning only.

ekes’s picture

ekes commented

I think it's good to get this merged and open issues / prs to tidy up any of the errors.

  • ekes committed 3788644b on 1.0.x authored by millnut 
    Issue #3391749 by millnut: Setup Gitlab CI for automated testing
ekes’s picture

ekes commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

millnut closed merge request !6