Problem/Motivation

The test-only issue #3386566: Add support for 'test only' changes to gitlab CI commit introduced dump of all variables in the GitlabCI again. This was Fixed by #3387916: Each GitLab job exposes user email in the past. See the relevant code:

'🩹 Test-only changes':
  ...
  script:
    ...
    - export

We should remove the export, as the purpose was only for debugging.

Steps to reproduce

See the test-only job output: https://git.drupalcode.org/issue/drupal-2820586/-/jobs/132773

Proposed resolution

Remove the export.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3391114

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

poker10 created an issue. See original summary.

poker10’s picture

poker10 commented
Issue summary: View changes

poker10 opened merge request !4919

poker10’s picture

poker10 commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

LGTM

  • catch committed cb55a3ae on 11.x 
    Issue #3391114 by poker10: Remove variables export from test-only job
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

  • catch committed 87f4270f on 10.1.x 
    Issue #3391114 by poker10: Remove variables export from test-only job
jonathan1055’s picture

jonathan1055 commented

For info, in the contrib gitlab template we changed this so that the variables can be exported, but are not done by default. Also even when exported, the personal gitlab variables are removed. See #3388207: Allow showing debug information and the associated MR gitlab_templates/-/merge_requests/45

The specific change to solve this, and remove all the GITLAB_USER variables was
env | sort | sed -E '/^(GITLAB_USER).*/d'

poker10’s picture

poker10 commented

Thanks. If this will be beneficial for core, let's create a child issue here #3387107: [meta] GitLab CI feature parity with DrupalCI, so that something similar can be added to core as well (this fix was only about the test-only job, but I think that we would then want to allow exports for all jobs, not only this one).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.