Problem/Motivation

Currently validation fails for addresses with address line 1 like this one 11A, rte de Soral

Steps to reproduce

Proposed resolution

First let's try with a second regex that runs if the first one failed to find a house number. Another option could be to split the address line field via javascript.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 commerce_swiss_post-address-line1-3389905-9.patch4.23 KBprimsi
#9 commerce_swiss_post-address-line1-3389905-9.interdiff.txt456 bytesprimsi
#7 commerce_swiss_post-address-line1-3389905-7.patch4.1 KBprimsi
#6 commerce_swiss_post-address-line1-3389905-6.patch2.13 KBprimsi
#6 commerce_swiss_post-address-line1-3389905-6.interdiff.txt2.5 KBprimsi
#5 commerce_swiss_post-address-line1-3389905-5.patch1.97 KBprimsi
#4 commerce_swiss_post-address-line1-3389905-4.patch1.97 KBprimsi
#4 commerce_swiss_post-address-line1-3389905-4.interdiff.txt1.61 KBprimsi
#3 commerce_swiss_post-address-line1-3389905-3.patch949 bytesprimsi
#2 commerce_swiss_post-address-line1-3389905-2.patch621 bytesprimsi

Comments

Primsi created an issue. See original summary.

primsi’s picture

primsi commented
Status: Active » Needs review
StatusFileSize
new commerce_swiss_post-address-line1-3389905-2.patch621 bytes

Initial try.

primsi’s picture

primsi commented
StatusFileSize
new commerce_swiss_post-address-line1-3389905-3.patch949 bytes

Added option to capture house address in 10/8 form to the first regex and updated the second one.

primsi’s picture

primsi commented
StatusFileSize
new commerce_swiss_post-address-line1-3389905-4.interdiff.txt1.61 KB
new commerce_swiss_post-address-line1-3389905-4.patch1.97 KB

If the first regex matches, then the ouput street is used, which then produces unwanted results

primsi’s picture

primsi commented
StatusFileSize
new commerce_swiss_post-address-line1-3389905-5.patch1.97 KB

Removing debug leftover.

primsi’s picture

primsi commented
StatusFileSize
new commerce_swiss_post-address-line1-3389905-6.interdiff.txt2.5 KB
new commerce_swiss_post-address-line1-3389905-6.patch2.13 KB

Adding tests.

primsi’s picture

primsi commented
StatusFileSize
new commerce_swiss_post-address-line1-3389905-7.patch4.1 KB

Doh, the tests were in a new file ...

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/src/AddressVerification.php
@@ -79,28 +79,13 @@ class AddressVerification {
+      $matched = static::verifyAddress($street);

@@ -181,4 +166,37 @@ class AddressVerification {
+  public static function extractStreetParts(string $street_line) {

method name doesn't match?

primsi’s picture

primsi commented
Status: Needs work » Needs review
StatusFileSize
new commerce_swiss_post-address-line1-3389905-9.interdiff.txt456 bytes
new commerce_swiss_post-address-line1-3389905-9.patch4.23 KB

Thanks.

  • Berdir committed 4348873a on 1.0.x authored by Primsi 
    Issue #3389905 by Primsi: Handle addresses where address line 1 starts...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.