Problem/Motivation

Fix spelling of words only misspelled in tests, part 2

I found these words by applying #3379121: Skip spellcheck for 20 nonsense words that are parts of hashes and #3328741: Add a dictionary for Drupal-specific words and then searching core test for the words in the dictionary where the word is used in a variable name. And also avoided the more challenging words, like the one that have a 'able' suffix or an 'un prefix.

Steps to reproduce

Proposed resolution

Correct spelling for these words and remove word from dictionary.

  1. alterjs
  2. boskoop
  3. boskop
  4. drup
  5. editunblock
  6. filestorage
  7. foos
  8. newstr
  9. newterm
  10. projecta
  11. projectb
  12. rolename
  13. sourcedir
  14. targetdir
  15. tempfile
  16. tempuser

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3389286

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Issue summary: View changes

quietone opened merge request !4862

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue tags: +cspell error
quietone’s picture

quietone commented
Status: Active » Needs review
quietone’s picture

quietone commented
Issue summary: View changes
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

"ditka_bears_node" clearly someone was a Chicago bears fan.

Read the changes and they make sense.

xjm made their first commit to this issue’s fork.

  • xjm committed 98754894 on 11.x 
    Issue #3389286 by quietone: Fix spelling of words only misspelled in...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Reviewed locally with git diff --color-words to ensure all the changes were correct spelling fixes. I also checked each changed word against the removals from the dictionary (which is important for these variable renames because we could introduce dead code or things testing what they're not meant to test if we missed an instance).

Committed to 11.x and cherry-picked to 10.1.x. Thanks!

  • xjm committed 76fc11d3 on 10.1.x 
    Issue #3389286 by quietone: Fix spelling of words only misspelled in...
xjm’s picture

xjm
she/her
Primary language English
commented

This issue didn't credit me, so making a new comment per DA request for debugging.

quietone closed merge request !4862

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.