Problem/Motivation

Currently the tests are failing and there are 6 code style issues. No idea why and when it broke! Hope it's still working in fact...

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork webform_ct-3389136

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

Grevil made their first commit to this issue’s fork.

Grevil opened merge request !7

grevil’s picture

grevil commented

Interesting! Now we have a different failure using the gitlab pipeline.

grevil’s picture

grevil commented

Somewhere, the tests for unsupported confirmation types were commented in again. See #3314878: Module currently only works with Confirmation type "Page" and "Inline".

grevil’s picture

grevil commented
Status: Active » Needs review
Related issues: +#3314878: Module currently only works with Confirmation type "Page" and "Inline"

All done, please review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

@Grevil failed pipeline?

grevil’s picture

grevil commented

Yea, he doesn't seem to require the "webform" dependency properly... For some reason, this now also gets thrown on the main branch....
Maybe we need to specify testing dependencies now with gitlab ci?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Reviewed & tested by the community

Code LGTM btw!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Needs work

@Grevil: Perhaps we need webform:webform_ui as test dependency? Do the tests use the UI? If yes, that's the reason. For production the UI isn't required.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Reviewed & tested by the community

Once the tests go green, please merge this and tag a new release.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Needs work

Sry - prepopulated select

grevil’s picture

grevil commented

No, we are not using the "webform_ui". I'll add the test_dependencies.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@Grevil: Commented

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Reviewed & tested by the community

Ok I think our code is fine, the real reason might be that webform has no stable Drupal 10 release, which breaks the dependencies. So let's merge this and add an issue to remember this reason. 95% sure.

  • Grevil committed b31a4565 on 1.0.x 
    Issue #3389136: Fix failing tests and code style issues
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Aight, I'll create a follow-up issue!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.