Problem/Motivation

Getting Following errors/warnings:

FILE: C:\Users\KIIT\Desktop\moduleslist\revolt\revolt.theme
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
204 | WARNING | Unused variable $element.
----------------------------------------------------------------------

FILE: C:\Users\KIIT\Desktop\moduleslist\revolt\theme-settings.php
------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------
49 | WARNING | #description values usually have to run through t() for translation
51 | WARNING | #options values usually have to run through t() for translation
52 | WARNING | #options values usually have to run through t() for translation
53 | WARNING | #options values usually have to run through t() for translation
85 | WARNING | #description values usually have to run through t() for translation
86 | WARNING | #options values usually have to run through t() for translation
86 | WARNING | #options values usually have to run through t() for translation
------------------------------------------------------------------------------------

Time: 554ms; Memory: 16MB

CommentFileSizeAuthor
#10 Fixed_Coding_standards-3387977.patch1.06 KBabhiyanshu
#10 coding_standards_issue_on_twig_file.png42.1 KBabhiyanshu

Issue fork revolt-3387977

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Shreya_th created an issue. See original summary.

Shreya_th opened merge request !3

shreya_th’s picture

shreya_th commented

Hi @yogesh.k,
I have created MR for Drupal Coding Standards Issues .Kindly review the changes.

Thank you.

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented
Status: Active » Needs work

@Shreya_th, thanks for your fast contribution. The other 2 files look nice, but the change you've made on revolt.theme file is not a good practice. Maybe there could be a better way for getting rid of that warning, than commenting out the line.

Best,
Orkut

shreya_th’s picture

shreya_th commented

Yes @Orkut Murat Yilmaz i will make change in revolt.theme file asap.

Thank you

paulrad’s picture

paulrad commented

@Shreya_th, this hook isn't used so you could just remove lines 199-205.

shreya_th’s picture

shreya_th commented
Status: Needs work » Needs review

Hi everyone,
I have done the changes told by @paulrad . Kindly review the changes .

Thank you.

sarwan_verma’s picture

sarwan_verma commented
Status: Needs review » Reviewed & tested by the community

Hi everyone, I have tested the MR and it fixes the issue. Moving it to the RTBC.

yogesh.k’s picture

yogesh.k commented
Status: Reviewed & tested by the community » Needs review
abhiyanshu’s picture

abhiyanshu commented
StatusFileSize
new coding_standards_issue_on_twig_file.png42.1 KB
new Fixed_Coding_standards-3387977.patch1.06 KB

@Shreya_th,
"I have carefully reviewed your changes and found that the code is running smoothly for three of the files. However, there is still one lingering linting error in the views-mini-pager.html.twig file.
I've taken the liberty to address this issue and have created a patch to rectify it.(Please refer to the attached patch)

With the fix in place, I'm now moving this to the 'RTBC' (Reviewed and Tested by the Community), Thank you.

abhiyanshu’s picture

abhiyanshu commented
Status: Needs review » Reviewed & tested by the community
shreya_th’s picture

shreya_th commented

@abhiyanshu_rawat ,
Thank you for pointing out the issue , I have applied your patch and it is running successfully. I have added your patch changes and raised the PR. Please review and verify.

yogesh.k’s picture

yogesh.k commented

pkghang made their first commit to this issue’s fork.

  • pkghang committed fe12d670 on 1.0.x authored by Shreya_th 
    Issue #3387977 by Shreya_th, abhiyanshu_rawat, yogesh.k, Orkut Murat...
pkghang’s picture

pkghang commented
Status: Reviewed & tested by the community » Fixed
orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented
Status: Fixed » Patch (to be ported)

It would be better to create a new release, after merging is done. Please check this documentation.

Best,
Orkut

yogesh.k’s picture

yogesh.k commented
Version: 1.0.2 » 1.0.3
Status: Patch (to be ported) » Fixed
yogesh.k’s picture

yogesh.k commented
Status: Fixed » Closed (fixed)
pkghang’s picture

pkghang commented
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.