Hello all,

Problem/Motivation

When I check the console of my browser, I get the error message which I paste below:

Uncaught TypeError: jQuery(...).once is not a function
    attach http://site.url/themes/contrib/vt_theme/js/vt-main.js?v=1.x:6
    attachBehaviors http://site.url/core/misc/drupal.js?v=10.1.3:166
    attachBehaviors http://site.urlcore/misc/drupal.js?v=10.1.3:162
    <anonymous> http://site.url/core/modules/big_pipe/js/big_pipe.js?v=10.1.3:118
    <anonymous> http://site.url/core/modules/big_pipe/js/big_pipe.js?v=10.1.3:138

Steps to reproduce

Install the theme and check browser console.

Proposed resolution

To add jquery.once to the dependencies will solve this problem.

Best,
Orkut

Issue fork vt_theme-3387971

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    1 hidden branch
  • master Comparechanges, plain diff MR !1

Issue fork revolt-3387971

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Orkut Murat Yılmaz created an issue. See original summary.

rushikesh raval’s picture

Please check it in project page it is Obsolete.

orkutmuratyilmaz’s picture

Project: Virasat theme » revolt
Version: 1.0.1 » 1.0.2

@rushiraval, thanks for your warning. Then, I'm migrating this issue to revolt.

orkutmuratyilmaz’s picture

Status: Active » Needs review

I've closed my first MR on the Virasat project and re-created it on revolt project. Also, I'm changing the status of this issue as "Needs review" respectively.

rushikesh raval’s picture

@Orkut Murat Yılmaz I have tested your patch. Still same error is there. you need to make necessary change in vt-main.js

You can refer : https://www.drupal.org/node/3158256

rushikesh raval’s picture

Status: Needs review » Needs work
omkar-pd’s picture

StatusFileSize
new1.14 KB

The patch will solve the issue. Replaced jquery/once with core/once.

omkar-pd’s picture

Status: Needs work » Needs review
rushikesh raval’s picture

Status: Needs review » Reviewed & tested by the community

I have test patch#10. It solve the problem. Moving it to RTBC

orkutmuratyilmaz’s picture

@omkar-pd, thanks for imroving my patch. It really works better.

This MR deserves a merge.

yogesh.k made their first commit to this issue’s fork.

yogesh.k’s picture

Status: Reviewed & tested by the community » Fixed
orkutmuratyilmaz’s picture

Status: Fixed » Patch (to be ported)

@yogesh.k, thanks for the merge, but it would be better to merge @omkar-pd's commit. My commit was buggy.

Shreya_th made their first commit to this issue’s fork.

shubham_jain made their first commit to this issue’s fork.

shubham_jain’s picture

Status: Patch (to be ported) » Needs review

Hi, raised MR for the patch file in the comment #10 and updated the MR raised by the @Orkut Murat Yılmaz.

Please review MR !6.

orkutmuratyilmaz’s picture

Version: 1.0.2 » 1.0.3
Status: Needs review » Reviewed & tested by the community

I'd like to inform that MR !6 is working. Now I'm changing issue status as RTBC and version as 1.0.3.

Also, it could be a better practice to create a dev release, in order to collect commits and merge requests too.

yogesh.k’s picture

Version: 1.0.3 » 1.0.8
Status: Reviewed & tested by the community » Fixed
yogesh.k’s picture

Status: Fixed » Closed (fixed)
pkghang’s picture

Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.