Hello all,
Problem/Motivation
When I check the console of my browser, I get the error message which I paste below:
Uncaught TypeError: jQuery(...).once is not a function
attach http://site.url/themes/contrib/vt_theme/js/vt-main.js?v=1.x:6
attachBehaviors http://site.url/core/misc/drupal.js?v=10.1.3:166
attachBehaviors http://site.urlcore/misc/drupal.js?v=10.1.3:162
<anonymous> http://site.url/core/modules/big_pipe/js/big_pipe.js?v=10.1.3:118
<anonymous> http://site.url/core/modules/big_pipe/js/big_pipe.js?v=10.1.3:138Steps to reproduce
Install the theme and check browser console.
Proposed resolution
To add jquery.once to the dependencies will solve this problem.
Best,
Orkut
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | jquery-once-dependency-3387971-10.patch | 1.14 KB | omkar-pd |
Issue fork vt_theme-3387971
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- master
changes, plain diff MR !1
1 hidden branch
Issue fork revolt-3387971
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- revolt-3387971-1
changes, plain diff MR !6
- 1.0.x
changes, plain diff MR !2
- 3387977-fixed-phpcs-issue
changes, plain diff MR !5
Comments
Comment #3
rushikesh raval commentedPlease check it in project page it is Obsolete.
Comment #4
orkutmuratyilmaz@rushiraval, thanks for your warning. Then, I'm migrating this issue to revolt.
Comment #7
orkutmuratyilmazI've closed my first MR on the Virasat project and re-created it on revolt project. Also, I'm changing the status of this issue as "Needs review" respectively.
Comment #8
rushikesh raval commented@Orkut Murat Yılmaz I have tested your patch. Still same error is there. you need to make necessary change in vt-main.js
You can refer : https://www.drupal.org/node/3158256
Comment #9
rushikesh raval commentedComment #10
omkar-pd commentedThe patch will solve the issue. Replaced jquery/once with core/once.
Comment #11
omkar-pd commentedComment #12
rushikesh raval commentedI have test patch#10. It solve the problem. Moving it to RTBC
Comment #13
orkutmuratyilmaz@omkar-pd, thanks for imroving my patch. It really works better.
This MR deserves a merge.
Comment #16
yogesh.k commentedComment #17
orkutmuratyilmaz@yogesh.k, thanks for the merge, but it would be better to merge @omkar-pd's commit. My commit was buggy.
Comment #23
shubham_jain commentedHi, raised MR for the patch file in the comment #10 and updated the MR raised by the @Orkut Murat Yılmaz.
Please review MR !6.
Comment #24
orkutmuratyilmazI'd like to inform that MR !6 is working. Now I'm changing issue status as RTBC and version as 1.0.3.
Also, it could be a better practice to create a dev release, in order to collect commits and merge requests too.
Comment #26
yogesh.k commentedComment #27
yogesh.k commentedComment #28
pkghang commented