Problem/Motivation
In #3386076: GitLab CI integration for core we added two new arguments to the run-tests.sh to allow paralell runs, but the simpletest_script_help() was not updated to describe these new parameters.
diff --git a/core/scripts/run-tests.sh b/core/scripts/run-tests.sh
@@ -404,6 +404,8 @@ function simpletest_script_parse_args() {
'xml' => '',
'non-html' => FALSE,
+ 'ci-parallel-node-index' => 1,
+ 'ci-parallel-node-total' => 1,
@@ -1024,6 +1026,12 @@ function simpletest_script_get_test_list() {
+ if ((int) $args['ci-parallel-node-total'] > 1) {
+ $tests_per_job = ceil(count($test_list) / $args['ci-parallel-node-total']);
+ $test_list = array_slice($test_list, ($args['ci-parallel-node-index'] - 1) * $tests_per_job, $tests_per_job);
+ }
I think we should add at least a brief description here.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3387959
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3387959-document-new-arguments
changes, plain diff MR !4809
Comments
Comment #3
poker10 commentedAdded an MR with this change. I have added only a brief description to the both arguments (taken from https://docs.gitlab.com/ee/ci/variables/predefined_variables.html), but can be tweaked if needed.
Comment #4
poker10 commentedComment #5
smustgrave commentedDocument changes read well and short and sweet to what the parameters do. +1
Comment #6
xjmComment #9
xjmCommitted to 11.x, 10.2.x, and 10.1.x as a developer documentation bugfix. Thanks!
Comment #13
xjmAmending attribution.