Problem/Motivation

To fix simple cleanups where we were declaring null return types which is against the standard but still accurate docs.

As requested in #2722647-59: [Meta] Fix Drupal.Commenting.FunctionComment.InvalidNoReturn

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3387950-2.patch1.04 KBquietone

Issue fork drupal-3387950

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
StatusFileSize
new 3387950-2.patch1.04 KB

quietone opened merge request !4821

quietone’s picture

quietone commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Simple cleanup

Searched for return Null and also found DrupalKernelTest but since that's a test assuming it doesn't count.

+1

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Actually, I would include #5 and any other instances we can identify in the scope. Thanks!

ashley_herodev made their first commit to this issue’s fork.

ashley_herodev’s picture

ashley_herodev commented

Ops, my IDE messed with Drupal's code standards, I will try to fix it

ashley_herodev’s picture

ashley_herodev commented
Status: Needs work » Needs review

Hiding old patch for clarity

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Thanks left comment on MR.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review

Setting back to NR -- I think it is out of scope to remove the additional documentation about the methods being no-ops. The methods don't make any sense without that information. 🙂

Pipeline failure looks to be a random:

    PHPUnit Test failed to complete; Error: PHPUnit 9.6.8 by Sebastian Bergmann
    and contributors.
    
    Testing
    Drupal\Tests\media_library\FunctionalJavascript\FieldUiIntegrationTest
    E                                                                   1 / 1
    (100%)
    
    Time: 00:35.960, Memory: 4.00 MB
    
    There was 1 error:
    
    1)
    Drupal\Tests\media_library\FunctionalJavascript\FieldUiIntegrationTest::testFieldUiIntegration
    Behat\Mink\Exception\ExpectationException: Checkbox "set_default_value" is
    not checked, but it should be.
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Sounds good @xjm.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8d14c6d9ad to 11.x and 15f7124382 to 10.2.x and 8b18a246b6 to 10.1.x. Thanks!

  • longwave committed 8b18a246 on 10.1.x 
    Issue #3387950 by quietone, ashley_herodev, smustgrave, xjm: Fix '@...

  • longwave committed 15f71243 on 10.2.x 
    Issue #3387950 by quietone, ashley_herodev, smustgrave, xjm: Fix '@...

  • longwave committed 8d14c6d9 on 11.x 
    Issue #3387950 by quietone, ashley_herodev, smustgrave, xjm: Fix '@...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.