Problem/Motivation

In , a coding standards change introduced a bug where selected-... classes from select elements were not correctly removed from the form element.

Steps to reproduce

  1. Configure a content type with a term entityreference field with "standard" and "extended" terms, defaulting to "standard"
  2. Visit node create form, note that form has class selected-standard
  3. Select "extended"
  4. Note that class selected-extended has been applied to the form
  5. Bug: Note that class selected-standard has not been removed from the form

Proposed resolution

  1. Add test coverage to verify expected behaviour (pipeline failing)
  2. Revert or fix the coding standards change

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

xurizaemon created an issue. See original summary.

xurizaemon’s picture

Issue summary: View changes
xurizaemon’s picture

Issue summary: View changes
xurizaemon’s picture

Since I landed the breaking change without review, I'm going to land the test and revert without review either.

ESLint tidy up can wait! I'll never trust ESLint again. (Of course I'm really responsible.)

  • xurizaemon committed 1e0821c8 on 2.0.x
    Issue #3387723: Fix (revert) for CSS selected-xxx behaviour
    
ericgsmith’s picture

Status: Active » Fixed

!11 was merged 2 years ago

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.