Problem/Motivation
In , a coding standards change introduced a bug where selected-... classes from select elements were not correctly removed from the form element.
Steps to reproduce
- Configure a content type with a term entityreference field with "standard" and "extended" terms, defaulting to "standard"
- Visit node create form, note that form has class
selected-standard - Select "extended"
- Note that class
selected-extendedhas been applied to the form - Bug: Note that class
selected-standardhas not been removed from the form
Proposed resolution
- Add test coverage to verify expected behaviour (pipeline failing)
- Revert or fix the coding standards change
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork advancedform-3387723
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
xurizaemonComment #4
xurizaemonComment #5
xurizaemonSince I landed the breaking change without review, I'm going to land the test and revert without review either.
ESLint tidy up can wait! I'll never trust ESLint again. (Of course I'm really responsible.)
Comment #7
ericgsmith commented!11 was merged 2 years ago