Problem/Motivation
The code still contains many coding standard errors. These can be seen locally using the DDEV tools.
Additionally they can be seen below the tests results at each test result page.
E.g. https://www.drupal.org/pift-ci-job/2755462 >> Click: XX coding standards messages
/var/www/html/modules/contrib/project_wiki/js/search.js
line 5 Unexpected unnamed function. (func-names)
7 'context' is defined but never used. (no-unused-vars)
7 'settings' is defined but never used. (no-unused-vars)
8 Replace `"projectWikiSearch",·".project-wiki-entries-list"` with `'projectWikiSearch',·'.project-wiki-entries-list'` (prettier/prettier)
8 Unexpected unnamed function. (func-names)
9 Insert `,` (prettier/prettier)
13 Replace `"project-wiki-entry-title"` with `'project-wiki-entry-title'` (prettier/prettier)
14 Replace `"project-wiki-entry-category"` with `'project-wiki-entry-category'` (prettier/prettier)
15 Replace `"project-wiki-entry-developerContent"` with `'project-wiki-entry-developerContent'` (prettier/prettier)
16 Replace `"project-wiki-entry-content"` with `'project-wiki-entry-content'` (prettier/prettier)
19 'entriesList' is assigned a value but never used. (no-unused-vars)
19 'List' is not defined. (no-undef)
css/list.css
4 Expected (flex-start | flex-end | center | space-between | space-around) but found 'space-evenly'.
modules/project_wiki_entity_content/README.md
14 Line exceeds 80 characters; contains 96 characters
20 Line exceeds 80 characters; contains 95 characters
27 Line exceeds 80 characters; contains 98 characters
31 Line exceeds 80 characters; contains 107 characters
33 Line exceeds 80 characters; contains 84 characters
37 Line exceeds 80 characters; contains 88 characters
modules/project_wiki_markdown_content/README.md
14 Line exceeds 80 characters; contains 96 characters
19 Line exceeds 80 characters; contains 95 characters
26 Line exceeds 80 characters; contains 109 characters
27 Line exceeds 80 characters; contains 99 characters
28 Line exceeds 80 characters; contains 114 characters
33 Line exceeds 80 characters; contains 102 characters
34 Line exceeds 80 characters; contains 114 characters
35 Line exceeds 80 characters; contains 115 characters
36 Line exceeds 80 characters; contains 111 characters
40 Line exceeds 80 characters; contains 112 characters
41 Line exceeds 80 characters; contains 111 characters
modules/project_wiki_markdown_content_example/Examples/en/Help for developers/markdown_example.md
7 Line exceeds 80 characters; contains 116 characters
10 Line exceeds 80 characters; contains 220 characters
12 Line exceeds 80 characters; contains 120 characters
23 Line exceeds 80 characters; contains 99 characters
24 Line exceeds 80 characters; contains 95 characters
26 Line exceeds 80 characters; contains 149 characters
27 Line exceeds 80 characters; contains 101 characters
28 Line exceeds 80 characters; contains 148 characters
29 Line exceeds 80 characters; contains 140 characters
40 Line exceeds 80 characters; contains 139 characters
42 Line exceeds 80 characters; contains 123 characters
modules/project_wiki_markdown_content_example/Examples/en/Help for developers/module_setup.md
8 Line exceeds 80 characters; contains 96 characters
9 Line exceeds 80 characters; contains 153 characters
10 Line exceeds 80 characters; contains 93 characters
11 Line exceeds 80 characters; contains 158 characters
13 Line exceeds 80 characters; contains 131 characters
14 Line exceeds 80 characters; contains 172 characters
15 Line exceeds 80 characters; contains 162 characters
16 Line exceeds 80 characters; contains 131 characters
17 Line exceeds 80 characters; contains 149 characters
18 Line exceeds 80 characters; contains 87 characters
modules/project_wiki_markdown_content_example/README.md
13 Line exceeds 80 characters; contains 123 characters
18 Line exceeds 80 characters; contains 95 characters
README.md
4 Line exceeds 80 characters; contains 102 characters
5 Line exceeds 80 characters; contains 102 characters
23 Line exceeds 80 characters; contains 100 characters
29 Line exceeds 80 characters; contains 95 characters
tests/src/FunctionalJavascript/ProjectWikiListjsTest.php
66 No space found before comment text; expected "// $session->statusCodeEquals(200);" but found "//$session->statusCodeEquals(200);"
72 No space found before comment text; expected "// $session->statusCodeEquals(200);" but found "//$session->statusCodeEquals(200);"
79 No space found before comment text; expected "// $session->statusCodeEquals(200);" but found "//$session->statusCodeEquals(200);"
81 No space found before comment text; expected "// $session->statusCodeEquals(200);" but found "//$session->statusCodeEquals(200);"
Please fix all that make sense to fix. Don't do it manually, use the IDE and DDEV tools!
And take care to not introduce them first. DDEV should be configured to report and fix most of them automatically.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comments
Comment #2
anybodyPlease also use this issue to fix the last failing test, so it becomes green again in 1.x!
Comment #4
shreya_th commentedComment #5
anybody@Shreya_th any plan to entirely resolve this NOW? Otherwise please stop unassinging other users!
Comment #6
shreya_th commented@Anybody I'm working on this .Just give me few minutes.
Comment #7
anybodyThank you! You have all time you need ;) But unassigning someone shouldn't be done this way.
Comment #8
shreya_th commentedHi @Anybody ,
I have fixed all the coding standard issues and failed test issues .Kindly review the patch file with attached screenshot as well.
Thank you.
Comment #9
anybody@Shreya_th thanks, again as MR please.
Comment #10
anybodyComment #12
shreya_th commentedHi @Anybody ,
Created MR for coding standard issues and failing test .Kindly review the changes.
Thank you.
Comment #13
anybodyComment #14
anybodyThanks @Shreya_th, I left some comments. The two failing tests please still need to be solved.
Comment #15
shubham_jain commentedComment #18
anybodyTests are still failing sadly.
Comment #19
shreya_th commented@Anybody will you please pointout in which file tests are failing or it will be easy for me to figure out failing tests issues if you will attach screenshot .
Comment #20
anybody@Shreya_th see this link: https://www.drupal.org/pift-ci-job/2765598 (red one here in the issue)
Comment #21
shreya_th commentedHi @Anybody ,
There is 500 response error which means Internal server error. So, we can't fix those errors. Those errors can only be fixed by your side.
Another errors are happening because of that one error I think. Please check it.
Comment #22
anybodyWell, of course the reasons can be fixed here, but we surely need to find out, why that happens. Does the same happen when running the tests locally?
Comment #23
shubham_jain commentedHi, I have tested this at my local also but the errors didn't occur in my local. I think this is something that is at server side. Only a guy with the devops knowledge can help in this.
Comment #24
anybody@Grevil: Could you take a short look, please to clarify the situation?
Comment #27
shiv_yadavComment #29
anybodyComment #30
grevil commentedComment #31
lrwebks commentedPromoting this to major as a lot of issues simply have unrelated failing pipelines due to this, so I will try to get this one out of the way quickly.
Comment #32
lrwebks commentedAs far as I can see, a lot of code has changed since we have opened this issue (nearly every file has a merge conflict). So I suppose it would be faster for us all if I would just open a second MR with the current 1.x branch and quickly resolve everything there.
Comment #35
lrwebks commentedWell, I first assumed that the test was failing because of load times (leading to inconsistent checks), but after letting the test sit for a whole 5 seconds after every search query, the error persists, and it is becoming incomprehensible to me. :P @grevil wanted to take over, so I will let him take a look at this.
Comment #36
anybody@lrwebks does this also fail locally?
I don't think it's a task for @Grevil. Did you have a look into the test results locally and replayed the html files linked? That should show you, what goes wrong.
Is a quite clear message, please first try to resolve it yourself.
Did you also replay the steps manually to ensure it's not simply expected behavior now?
Comment #37
lrwebks commentedIndeed, I have looked through the generated HTML files and tested it many times locally as well as manually (It definitely works with manual testing in the UI!). My impression is that the failure is related to the test environment itself and the fact that the results don't get loaded/unloaded immediately, but after a small delay due to JS (the test check might simply be too fast for listjs to load).
@Grevil asked me to let him take over to work on the failing test, so I'll assign this back to him.
Comment #40
anybodyAll done, let's see! BTW from my perspective the required changes are obvious. Looking into the HTML test results shows that things already work perfectly, but the tests were wrong. listjs hides contents, so of course the're still in the DOM!
Comment #41
anybodyComment #42
anybodyComment #44
anybody