Problem/Motivation

Currently, the id attribute for the form_mode_container form element is an array, but it should be a string. The id attribute may be used in theme suggestions, and having the id as an array may cause fatal errors.

Proposed resolution

Change the id attribute to a string.

CommentFileSizeAuthor
#5 forms_steps-form_attribute_issue-3386999-5.patch468 bytesid.aleks

Issue fork forms_steps-3386999

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

id.aleks created an issue. See original summary.

id.aleks opened merge request !15

id.aleks closed merge request !15

id.aleks opened merge request !16

id.aleks’s picture

id.aleks commented
Status: Active » Needs review
StatusFileSize
new forms_steps-form_attribute_issue-3386999-5.patch468 bytes

I have created MR. Also adding a patch.

id.aleks’s picture

id.aleks commented
Assigned: id.aleks » Unassigned
id.aleks’s picture

id.aleks commented
Related issues: +#3218877: Labels do not have correct 'for' attribute if 'id' set in #attributes

nicoloye closed merge request !16

nicoloye’s picture

nicoloye commented
Status: Needs review » Reviewed & tested by the community

Patch is working fine, thanks!

  • id.aleks authored a75f51f6 on 8.x-1.x 
    Issue #3386999 by id.aleks: The 'form_mode_container' form element's 'id...
nicoloye’s picture

nicoloye commented
Status: Reviewed & tested by the community » Fixed

Push to dev branch. Ready for next release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.