The JS is currently slightly 🍝, and needs to be refactored. Right now it's in one big behavior and many functions could be split up or combined.
Issue fork navigation-3386509
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
mherchelI'm working on this
Comment #4
mherchelThis is ready for review. Note I'd like to get this in ASAP, as any further JS work will conflict with this.
Comment #5
ckrinaI've tested it and it works the same as it did, so no bugs introduced. Plus the code looks good. I'd rather merge this and work on top of that for any further change. Thanks Mike!
Comment #6
finnsky commentedI would also manage black hover text with floating UI here.
Because now when we put submenu to fixed position it works fine with sidebar overflow: hidden
But that black text is not
https://gyazo.com/9198c0e3806e21c9107f1c20cca756d4
Comment #7
ckrina@finnsky I'd keep improvements to smaller follow-ups to avoid conflicts, and leave this to a refactor :)
Comment #9
mherchelComment #11
mherchelCommitted dbba902c