The JS is currently slightly 🍝, and needs to be refactored. Right now it's in one big behavior and many functions could be split up or combined.

Issue fork navigation-3386509

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mherchel created an issue. See original summary.

mherchel’s picture

Assigned: Unassigned » mherchel

I'm working on this

mherchel’s picture

Status: Active » Needs review

This is ready for review. Note I'd like to get this in ASAP, as any further JS work will conflict with this.

ckrina’s picture

Status: Needs review » Reviewed & tested by the community

I've tested it and it works the same as it did, so no bugs introduced. Plus the code looks good. I'd rather merge this and work on top of that for any further change. Thanks Mike!

finnsky’s picture

I would also manage black hover text with floating UI here.
Because now when we put submenu to fixed position it works fine with sidebar overflow: hidden
But that black text is not

https://gyazo.com/9198c0e3806e21c9107f1c20cca756d4

ckrina’s picture

@finnsky I'd keep improvements to smaller follow-ups to avoid conflicts, and leave this to a refactor :)

mherchel’s picture

  • mherchel committed dbba902c on 1.x
    Issue #3386509 by mherchel, ckrina, claireristow: Refactor JavaScript
    
mherchel’s picture

Status: Reviewed & tested by the community » Fixed

Committed dbba902c

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.