Problem/Motivation

FileOnTranslatedEntityTest uses form submissions to change language settings.

This is expensive, and not what the test is covering.

Steps to reproduce

Proposed resolution

Change to API calls.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3385846

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Issue tags: +Novice

Tagging for new users as may be some good practice with refactoring tests.

pooja_sharma made their first commit to this issue’s fork.

pooja_sharma opened merge request !9109

pooja_sharma’s picture

pooja_sharma commented
Status: Active » Needs review
Issue tags: +Test suite performance

Added API() & removed the http request, also observed additional duplicate code removed this as well, apart from it nothing seems to be left.

Also verified test changes on local, its output on the basis of time & memory usage as follow:

Before applied MR changes test takes : Time: 00:17.703, Memory: 6.00 MB

After applied MR changes test takes: Time: 00:14.922, Memory: 6.00 MB

Please review, moving NR.

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

LGTM.

  • catch committed ec68e702 on 10.4.x 
    Issue #3385846 by pooja_sharma, joachim: FileOnTranslatedEntityTest...

  • catch committed e41b685b on 11.0.x 
    Issue #3385846 by pooja_sharma, joachim: FileOnTranslatedEntityTest...

  • catch committed b6c3c60a on 11.x 
    Issue #3385846 by pooja_sharma, joachim: FileOnTranslatedEntityTest...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, cherry-picked to 11.0.x and 10.4.x, thanks!

  • catch committed 5305397f on 10.3.x 
    Issue #3385846 by pooja_sharma, joachim: FileOnTranslatedEntityTest...

catch closed merge request !9109

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.