Problem/Motivation

  • Fix an error if no glyphicon is set for a button.
    1. Internal server error occurs when accessing a Form in which the glyphicon is not set for the cancel button.
    2. Fix the style of the login button in actions.
    • actions-login
CommentFileSizeAuthor
actions-login.png40.88 KBsekinet

Issue fork rigel-3384733

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

sekinet created an issue. See original summary.

sekinet’s picture

Status: Active » Needs review

@yas

Could you please review the patch?

yas’s picture

Status: Needs review » Needs work

@sekinet

Thank you for the fix. I posted my comment. Thanks

sekinet’s picture

Status: Needs work » Needs review

@yas

Thank you for your comment. I fixed, could you please check it?

yas’s picture

Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the update. It looks more cleaner. I'll merge the patch to 6.x, and close this issue as Fixed.

  • yas committed c544570e on 6.x authored by sekinet
    Issue #3384733 by sekinet, yas: Fix an error if no glyphicon is set for...

  • yas committed 574e4708 on 5.x authored by sekinet
    Issue #3384733 by sekinet, yas: Fix an error if no glyphicon is set for...
yas’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

sekinet’s picture

Status: Fixed » Needs review

@yas

I pushed the coding check fixes to the hotfix-3384733-fix-an-error-if-no-glyphicon-is-set-for-a-button branch. Could you please check it?

yas’s picture

@sekinet

I didn't see any patch at the branch "hotfix-3384733-fix-an-error-if-no-glyphicon-is-set-for-a-button". Can you please double-check it?

Thanks

sekinet’s picture

@yas

Sorry, I pushed again, could you please check?

yas’s picture

Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 092f7081 on 6.x authored by sekinet
    Issue #3384733 by sekinet, yas: Hotfix - Fix an error if no glyphicon is...

  • yas committed b0ff6b22 on 5.x authored by sekinet
    Issue #3384733 by sekinet, yas: Hotfix - Fix an error if no glyphicon is...
yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.