Problem/Motivation

Upon upgrading from 1.3.0 to 1.3.1, the Address module form widget stopped working. It is no longer displayed.
Reverting to 1.3.0 fixes the issue.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

badmothergoose created an issue. See original summary.

badmothergoose’s picture

Issue summary: View changes
rodrigoaguilera’s picture

Version: 1.3.1 » 1.x-dev
Status: Active » Postponed (maintainer needs more info)

Can you provide more info?

What version of the address module? What settings do you use with the "Change labels" module? On which entities?

I did a quick test with the latest stable of address module, change labels 1.3.1 and changed the title of the filed without problems

https://master-3depmeiuqwteymejtxy2bxhemzk3hisi.tugboatqa.com/node/add/a...

badmothergoose’s picture

the module worked fine on 1.3.0 but broke the address module v. 8.x-1.12 widget with 1.3.1

i overwrite the address field label with <nolabel> on a node entity. The address field is in a tab (tabs>tab>address).

the widget was simply not being rendered (no html markup).

sorry i can't be much more specific, i would look into the diffs between 1.3.0 and 1.3.1. i suspect in fact the issue having to do with tabbing rather than address.

hope this helps

rodrigoaguilera’s picture

Do you use field_group also?

Can you share the yml config for the form_mode?

badmothergoose’s picture

there you go. hope this helps

uuid:
langcode: en
status: true
dependencies:
config:
- field.field.node.venue.field_address
- field.field.node.venue.field_email
- field.field.node.venue.field_geolocation
- field.field.node.venue.field_phone
- field.field.node.venue.field_url
- field.field.node.venue.field_venue_name
- node.type.venue
module:
- address
- change_labels
- conditional_fields
- field_group
- geolocation
- geolocation_address
- hide_revision_field
- link
- path
- telephone
third_party_settings:
field_group:
group_venue_details:
children:
- group_address
- group_other_info
- group_geolocation_manual_
label: 'venue details'
region: content
parent_name: ''
weight: 2
format_type: tabs
format_settings:
classes: ''
show_empty_fields: false
id: ''
direction: horizontal
width_breakpoint: 640
effect: none
group_address:
children:
- field_address
- field_venue_timezone
label: Address
region: content
parent_name: group_venue_details
weight: 5
format_type: tab
format_settings:
classes: ''
show_empty_fields: false
id: ''
formatter: open
description: ''
required_fields: true
group_other_info:
children:
- field_url
- field_email
- field_phone
label: 'Other info (optional)'
region: content
parent_name: group_venue_details
weight: 7
format_type: tab
format_settings:
classes: ''
show_empty_fields: false
id: ''
formatter: closed
description: ''
required_fields: true
group_geolocation_manual_:
children:
- field_geolocation
label: 'Geolocation (manual)'
region: content
parent_name: group_venue_details
weight: 8
format_type: tab
format_settings:
classes: ''
show_empty_fields: false
id: ''
formatter: closed
description: 'Only use for manual entry or reset of geolocation fields'
required_fields: true
id: node.venue.default
targetEntityType: node
bundle: venue
mode: default
content:
created:
type: datetime_timestamp
weight: 4
region: content
settings: { }
third_party_settings: { }
field_address:
type: address_default
weight: 8
region: content
settings: { }
third_party_settings:
change_labels:
field_label_overwrite: ''
field_email:
type: email_default
weight: 6
region: content
settings:
placeholder: ''
size: 60
third_party_settings: { }
field_geolocation:
type: geolocation_latlng
weight: 7
region: content
settings: { }
third_party_settings:
geolocation_address:
enable: true
address_field: field_address
geocoder: google_geocoding_api
settings:
label: Address
description: 'Enter an address to be localized.'
autocomplete_min_length: 1
component_restrictions:
route: ''
country: ''
administrative_area: ''
locality: ''
postal_code: ''
boundary_restriction:
south: ''
west: ''
north: ''
east: ''
region: ''
sync_mode: auto
button_position: LEFT_TOP
direction: one_way
ignore:
organization: false
address-line1: false
address-line2: false
locality: false
administrative-area: false
postal-code: false
conditional_fields: { }
field_phone:
type: telephone_default
weight: 7
region: content
settings:
placeholder: ''
third_party_settings: { }
field_url:
type: link_default
weight: 5
region: content
settings:
placeholder_url: ''
placeholder_title: ''
third_party_settings: { }
field_venue_name:
type: string_textfield
weight: 0
region: content
settings:
size: 60
placeholder: ''
third_party_settings: { }
group_geolocation_manual_:
weight: 26
region: content
settings: { }
third_party_settings:
conditional_fields: { }
langcode:
type: language_select
weight: 1
region: content
settings:
include_locked: true
third_party_settings: { }
path:
type: path
weight: 8
region: content
settings: { }
third_party_settings: { }
promote:
type: boolean_checkbox
weight: 5
region: content
settings:
display_label: true
third_party_settings: { }
revision_log:
type: hide_revision_field_log_widget
weight: 11
region: content
settings:
rows: 5
placeholder: ''
show: true
default: ''
permission_based: false
allow_user_settings: true
third_party_settings: { }
status:
type: boolean_checkbox
weight: 9
region: content
settings:
display_label: true
third_party_settings: { }
sticky:
type: boolean_checkbox
weight: 7
region: content
settings:
display_label: true
third_party_settings: { }
uid:
type: entity_reference_autocomplete
weight: 3
region: content
settings:
match_operator: CONTAINS
match_limit: 10
size: 60
placeholder: ''
third_party_settings: { }
url_redirects:
weight: 10
region: content
settings: { }
third_party_settings: { }
hidden:
title: true

rodrigoaguilera’s picture

Status: Postponed (maintainer needs more info) » Active

I was able to reproduce it setting "nolabel" on the address field. No field_group involved.

rodrigoaguilera’s picture

Status: Active » Fixed

Can you try the latest commit on the 1.x branch? I think I fixed the issue and added the ability to actually hide the label for an address field. I don't think it was working with 1.3.0 and claro.

Once you confirm I can roll a new release. Feel free to reopen the issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

badmothergoose’s picture

#8 fixes the issue. Muchas gracias por todo. please commit to next version.

rodrigoaguilera’s picture

Thanks for testing