Comments

gidarai created an issue. See original summary.

gidarai’s picture

StatusFileSize
new13.75 KB

First initial patch

gidarai’s picture

Status: Active » Needs review

changed status

Status: Needs review » Needs work

The last submitted patch, 2: 3384000-2.patch, failed testing. View results

gidarai’s picture

Status: Needs work » Needs review

Changed status back to "needs review" as the code errors aren't related to this patch

tanuja bohra’s picture

StatusFileSize
new38.99 KB
new11.48 KB

@gidarai, the text is changed on the configuration, but the icon is still showing the same.

snehal-chibde’s picture

Issue summary: View changes
StatusFileSize
new1.04 MB
new73.76 KB
new138.94 KB
new77.18 KB

Hello, applied patch #2. It is working as per requirement. Here are before and after screenshots for the same. RTBC++.

gidarai’s picture

StatusFileSize
new43.49 KB
new32.75 KB

@Tanuja Bohra Yes i was working on the icons for the frontend. Here is the patch including the frontend icon changes.

bram.velthoven’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new18 KB
new13.91 KB

Patch #8 works fine for me! Setting to RTBC

karibuplus’s picture

Patch #8 works for us as well.

shelane’s picture

Status: Reviewed & tested by the community » Needs work

The icons on the block configuration page still have the twitter bird. Also, there was a switch in the order of services in the template. That is beyond the scope of this issue. It's fine if you want to copy the template to your theme to change the order, but it shouldn't be changed here.

  • shelane committed b318e155 on 4.x
    Issue #3384000 by gidarai, shelane: Change twitter icon to the new "X"...
shelane’s picture

Status: Needs work » Fixed

I update the config pages and also changed the config values of the service from twitter to x. I included an update hook to update existing config.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.