| Comment | File | Size | Author |
|---|---|---|---|
| #9 | beforepatch-8.png | 13.91 KB | bram.velthoven |
| #9 | afterpatch-8.png | 18 KB | bram.velthoven |
| #8 | interdiff-2-8.txt | 32.75 KB | gidarai |
| #8 | 3384000-8.patch | 43.49 KB | gidarai |
| #6 | after_patch_1.png | 11.48 KB | tanuja bohra |
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | beforepatch-8.png | 13.91 KB | bram.velthoven |
| #9 | afterpatch-8.png | 18 KB | bram.velthoven |
| #8 | interdiff-2-8.txt | 32.75 KB | gidarai |
| #8 | 3384000-8.patch | 43.49 KB | gidarai |
| #6 | after_patch_1.png | 11.48 KB | tanuja bohra |
Comments
Comment #2
gidarai commentedFirst initial patch
Comment #3
gidarai commentedchanged status
Comment #5
gidarai commentedChanged status back to "needs review" as the code errors aren't related to this patch
Comment #6
tanuja bohra commented@gidarai, the text is changed on the configuration, but the icon is still showing the same.
Comment #7
snehal-chibde commentedHello, applied patch #2. It is working as per requirement. Here are before and after screenshots for the same. RTBC++.
Comment #8
gidarai commented@Tanuja Bohra Yes i was working on the icons for the frontend. Here is the patch including the frontend icon changes.
Comment #9
bram.velthoven commentedPatch #8 works fine for me! Setting to RTBC
Comment #10
karibuplus commentedPatch #8 works for us as well.
Comment #11
shelaneThe icons on the block configuration page still have the twitter bird. Also, there was a switch in the order of services in the template. That is beyond the scope of this issue. It's fine if you want to copy the template to your theme to change the order, but it shouldn't be changed here.
Comment #13
shelaneI update the config pages and also changed the config values of the service from twitter to x. I included an update hook to update existing config.